Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 2876223003: cocoa: add some tab-manipulation menu items (Closed)

Created:
3 years, 7 months ago by Elly Fong-Jones
Modified:
3 years, 7 months ago
Reviewers:
Robert Sesek, sky, shrike
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cocoa: add some tab-manipulation menu items This change adds these items to the Window menu: * Duplicate Tab * Pin Tab * Mute Tab The latter two are toggle-able menu items. BUG=699667 Review-Url: https://codereview.chromium.org/2876223003 Cr-Commit-Position: refs/heads/master@{#473202} Committed: https://chromium.googlesource.com/chromium/src/+/0101ba06c70108d8165c8e2f53e8f3069ab9478c

Patch Set 1 #

Total comments: 6

Patch Set 2 : unstage nib delta #

Total comments: 5

Patch Set 3 : add new IDS_ constants #

Patch Set 4 : clang-format life #

Patch Set 5 : remove top separator #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -1 line) Patch
M chrome/app/chrome_command_ids.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/app/nibs/MainMenu.xib View 1 2 3 4 2 chunks +19 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 1 2 3 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_commands.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_command_handler.mm View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 28 (9 generated)
Elly Fong-Jones
rsesek: ptal at chrome/browser/ui/cocoa changes and chrome/app/nibs/MainMenu.xib delta sky: ptal at other chrome/browser/ui stuff thanks ...
3 years, 7 months ago (2017-05-12 20:01:43 UTC) #3
sky
https://codereview.chromium.org/2876223003/diff/1/chrome/app/chrome_command_ids.h File chrome/app/chrome_command_ids.h (right): https://codereview.chromium.org/2876223003/diff/1/chrome/app/chrome_command_ids.h#newcode86 chrome/app/chrome_command_ids.h:86: #define IDC_WINDOW_DUPLICATE_TAB 35012 Can you keep the alignment as ...
3 years, 7 months ago (2017-05-14 15:45:03 UTC) #4
Robert Sesek
https://codereview.chromium.org/2876223003/diff/1/chrome/app/nibs/MainMenu.xib File chrome/app/nibs/MainMenu.xib (right): https://codereview.chromium.org/2876223003/diff/1/chrome/app/nibs/MainMenu.xib#newcode2 chrome/app/nibs/MainMenu.xib:2: <document type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="3.0" toolsVersion="11542" systemVersion="16F71b" targetRuntime="MacOSX.Cocoa" propertyAccessControl="none"> Does presubmit ...
3 years, 7 months ago (2017-05-15 18:44:03 UTC) #5
shrike
ellyjones@ - two comments. First, I think you should get rid of the divider between ...
3 years, 7 months ago (2017-05-15 20:23:23 UTC) #7
Elly Fong-Jones
rsesek, sky: ptal? shrike: okay - I'll add some new IDS_ constants for those strings ...
3 years, 7 months ago (2017-05-16 19:05:15 UTC) #8
Robert Sesek
https://codereview.chromium.org/2876223003/diff/20001/chrome/app/chrome_command_ids.h File chrome/app/chrome_command_ids.h (right): https://codereview.chromium.org/2876223003/diff/20001/chrome/app/chrome_command_ids.h#newcode86 chrome/app/chrome_command_ids.h:86: #define IDC_WINDOW_MUTE_TAB 35012 nit: alignment https://codereview.chromium.org/2876223003/diff/20001/chrome/browser/ui/browser_command_controller.cc File chrome/browser/ui/browser_command_controller.cc (right): ...
3 years, 7 months ago (2017-05-16 19:47:41 UTC) #9
sky
LGTM
3 years, 7 months ago (2017-05-17 16:30:12 UTC) #10
Elly Fong-Jones
shrike: ptal? :) https://codereview.chromium.org/2876223003/diff/20001/chrome/app/chrome_command_ids.h File chrome/app/chrome_command_ids.h (right): https://codereview.chromium.org/2876223003/diff/20001/chrome/app/chrome_command_ids.h#newcode86 chrome/app/chrome_command_ids.h:86: #define IDC_WINDOW_MUTE_TAB 35012 On 2017/05/16 19:47:41, ...
3 years, 7 months ago (2017-05-17 17:56:17 UTC) #11
Robert Sesek
https://codereview.chromium.org/2876223003/diff/20001/chrome/app/chrome_command_ids.h File chrome/app/chrome_command_ids.h (right): https://codereview.chromium.org/2876223003/diff/20001/chrome/app/chrome_command_ids.h#newcode86 chrome/app/chrome_command_ids.h:86: #define IDC_WINDOW_MUTE_TAB 35012 On 2017/05/17 17:56:16, Elly Fong-Jones wrote: ...
3 years, 7 months ago (2017-05-17 18:14:11 UTC) #12
Elly Fong-Jones
On 2017/05/17 18:14:11, Robert Sesek wrote: > https://codereview.chromium.org/2876223003/diff/20001/chrome/app/chrome_command_ids.h > File chrome/app/chrome_command_ids.h (right): > > https://codereview.chromium.org/2876223003/diff/20001/chrome/app/chrome_command_ids.h#newcode86 ...
3 years, 7 months ago (2017-05-17 18:43:45 UTC) #13
Elly Fong-Jones
On 2017/05/17 18:43:45, Elly Fong-Jones wrote: > On 2017/05/17 18:14:11, Robert Sesek wrote: > > ...
3 years, 7 months ago (2017-05-18 19:06:03 UTC) #14
shrike
On 2017/05/17 17:56:17, Elly Fong-Jones wrote: > shrike: ptal? :) The menu items look good. ...
3 years, 7 months ago (2017-05-18 19:32:05 UTC) #15
Elly Fong-Jones
On 2017/05/18 19:32:05, shrike wrote: > On 2017/05/17 17:56:17, Elly Fong-Jones wrote: > > shrike: ...
3 years, 7 months ago (2017-05-18 19:48:35 UTC) #16
Robert Sesek
LGTM
3 years, 7 months ago (2017-05-18 20:47:26 UTC) #17
shrike
lgtm
3 years, 7 months ago (2017-05-18 22:16:51 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876223003/80001
3 years, 7 months ago (2017-05-19 13:30:57 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/449816)
3 years, 7 months ago (2017-05-19 15:03:28 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876223003/80001
3 years, 7 months ago (2017-05-19 15:04:45 UTC) #25
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 15:50:45 UTC) #28
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/0101ba06c70108d8165c8e2f53e8...

Powered by Google App Engine
This is Rietveld 408576698