Add content addressed uploading helper function for render tests.

Add content addressed uploading helper function for render tests.

We will be uploading the same golden images over and over for
render tests. Uploading images by md5sum so that we can avoid
storing/uploading multiple copies of the same exact file.

Also CL fixes small bug in _IsRenderTest helper function. Now
properly identifies tests with RenderTest feature annotation.

Review-Url: https://codereview.chromium.org/2876183003
Cr-Commit-Position: refs/heads/master@{#471488}
Committed: https://chromium.googlesource.com/chromium/src/+/c5fdbf8734c0194ecf673f8627cfdbb0bbb9a895

[mikecase (-- gone --), 2017-05-12 16:58:37]

mikecase@chromium.org changed reviewers:
+ jbudorick@chromium.org, peconn@chromium.org

[mikecase (-- gone --), 2017-05-12 17:00:51]

The CQ bit was checked by mikecase@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 17:01:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbudorick, 2017-05-12 17:13:59]

Looks pretty good. Main question is about the hash.

https://codereview.chromium.org/2876183003/diff/20001/build/android/pylib/uti...
File build/android/pylib/utils/google_storage_helper.py (right):

https://codereview.chromium.org/2876183003/diff/20001/build/android/pylib/uti...
build/android/pylib/utils/google_storage_helper.py:22: from devil.android import
md5sum
Using this is fine (if not a bit unusual for a pure-host checksum), but I'm
wondering about using a bit longer hash here. (e.g. isolate uses sha1)

https://codereview.chromium.org/2876183003/diff/20001/build/android/pylib/uti...
build/android/pylib/utils/google_storage_helper.py:66: """Uploads data to Google
Storage with filename as md5sum hash. If file
nit:

"""Summary on one line.

Other lines.
"""

[mikecase (-- gone --), 2017-05-12 17:39:04]

https://codereview.chromium.org/2876183003/diff/20001/build/android/pylib/uti...
File build/android/pylib/utils/google_storage_helper.py (right):

https://codereview.chromium.org/2876183003/diff/20001/build/android/pylib/uti...
build/android/pylib/utils/google_storage_helper.py:22: from devil.android import
md5sum
On 2017/05/12 at 17:13:59, jbudorick wrote:
> Using this is fine (if not a bit unusual for a pure-host checksum), but I'm
wondering about using a bit longer hash here. (e.g. isolate uses sha1)

done. I agree this is definitely better

https://codereview.chromium.org/2876183003/diff/20001/build/android/pylib/uti...
build/android/pylib/utils/google_storage_helper.py:66: """Uploads data to Google
Storage with filename as md5sum hash. If file
On 2017/05/12 at 17:13:59, jbudorick wrote:
> nit:
> 
> """Summary on one line.
> 
> Other lines.
> """

Done

[jbudorick, 2017-05-12 17:42:09]

lgtm

[mikecase (-- gone --), 2017-05-12 17:55:14]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2017-05-12 17:56:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 19:54:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 19:54:15]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[mikecase (-- gone --), 2017-05-12 20:20:12]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2017-05-12 20:20:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 23:35:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494620412409970,
"parent_rev": "aee98b5c7aebe3c263f2150357d36901efbf0d53", "commit_rev":
"c5fdbf8734c0194ecf673f8627cfdbb0bbb9a895"}

[commit-bot: I haz the power, 2017-05-12 23:35:30]

Description was changed from

==========
Add content addressed uploading helper function for render tests.

We will be uploading the same golden images over and over for
render tests. Uploading images by md5sum so that we can avoid
storing/uploading multiple copies of the same exact file.

Also CL fixes small bug in _IsRenderTest helper function. Now
properly identifies tests with RenderTest feature annotation.
==========

to

==========
Add content addressed uploading helper function for render tests.

We will be uploading the same golden images over and over for
render tests. Uploading images by md5sum so that we can avoid
storing/uploading multiple copies of the same exact file.

Also CL fixes small bug in _IsRenderTest helper function. Now
properly identifies tests with RenderTest feature annotation.

Review-Url: https://codereview.chromium.org/2876183003
Cr-Commit-Position: refs/heads/master@{#471488}
Committed:
https://chromium.googlesource.com/chromium/src/+/c5fdbf8734c0194ecf673f8627cf...
==========

[commit-bot: I haz the power, 2017-05-12 23:35:31]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c5fdbf8734c0194ecf673f8627cf...