Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2876143002: Fix gn bootstrap after https://codereview.chromium.org/2872503003 (Closed)

Created:
3 years, 7 months ago by Nico
Modified:
3 years, 7 months ago
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gn bootstrap after https://codereview.chromium.org/2872503003 That change made field_trial.cc use a ScopedCrashKey, but crash_logging.cc (where that's defined) wasn't part of the build. Also fix an unrelated error on Mac where sys_info_mac.mm was missing. Also remove a few files that were listed twice, once in the unconditional section at the top and then again in the is_mac and is_win blocks. BUG=none Review-Url: https://codereview.chromium.org/2876143002 Cr-Commit-Position: refs/heads/master@{#471311} Committed: https://chromium.googlesource.com/chromium/src/+/777e1cd5ec01dc0f243dac99712beb3ca0f37db4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M tools/gn/bootstrap/bootstrap.py View 4 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Nico
3 years, 7 months ago (2017-05-12 14:44:22 UTC) #3
Alexei Svitkine (slow)
lgtm
3 years, 7 months ago (2017-05-12 14:45:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876143002/1
3 years, 7 months ago (2017-05-12 14:46:00 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 15:40:19 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/777e1cd5ec01dc0f243dac99712b...

Powered by Google App Engine
This is Rietveld 408576698