Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2876123004: media: Add mojo_media_config to media/gpu configs (Closed)

Created:
3 years, 7 months ago by xhwang
Modified:
3 years, 7 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Add mojo_media_config to media/gpu configs Otherwise, macros like ENABLE_MOJO_MEDIA_IN_GPU_PROCESS are not defined. We should switch to use BUILDFLAG to prevent this from happening, that is tracked by issue 596252. BUG=596252, 721935 TEST=Manually tested encrypted playback. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2876123004 Cr-Commit-Position: refs/heads/master@{#471553} Committed: https://chromium.googlesource.com/chromium/src/+/9d5f354616dea455ea08345c96b67081275a865d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M media/gpu/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
xhwang
I thought our content_browsertests should catch this, but apparently something went wrong. I'll double check. ...
3 years, 7 months ago (2017-05-12 21:30:56 UTC) #5
sandersd (OOO until July 31)
lgtm
3 years, 7 months ago (2017-05-12 22:06:29 UTC) #6
xhwang
Ah, the content_browsertests test the case where we use DecryptingVideoDecoder + MojoDecyrptor + CDM running ...
3 years, 7 months ago (2017-05-12 22:33:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876123004/1
3 years, 7 months ago (2017-05-12 22:34:23 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-13 03:57:54 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9d5f354616dea455ea08345c96b6...

Powered by Google App Engine
This is Rietveld 408576698