Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2876033002: diagnose_bloat.py: fix broken --subrepo. (Closed)

Created:
3 years, 7 months ago by estevenson
Modified:
3 years, 7 months ago
Reviewers:
agrieve
CC:
chromium-reviews, wnwen+watch_chromium.org, estevenson+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

diagnose_bloat.py: fix broken --subrepo. Broken in 40a227b, we currently don't build for subrepo (and the script fails). BUG=695182 Review-Url: https://codereview.chromium.org/2876033002 Cr-Commit-Position: refs/heads/master@{#471072} Committed: https://chromium.googlesource.com/chromium/src/+/5641ee8c6260a7ac4fddf464ed97ea81e74116d2

Patch Set 1 #

Patch Set 2 : user accept message spacing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M tools/binary_size/diagnose_bloat.py View 1 4 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
estevenson
I guess we haven't looked at any rolls for a while, whoops!
3 years, 7 months ago (2017-05-11 19:21:45 UTC) #2
agrieve
On 2017/05/11 19:21:45, estevenson wrote: > I guess we haven't looked at any rolls for ...
3 years, 7 months ago (2017-05-11 20:36:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876033002/20001
3 years, 7 months ago (2017-05-11 20:57:38 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 21:14:53 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5641ee8c6260a7ac4fddf464ed97...

Powered by Google App Engine
This is Rietveld 408576698