Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2875943003:
Cleanup: Remove dead code in NewTabUI (Closed)
|
Created:
3 years, 7 months ago by Marc Treib Modified:
3 years, 7 months ago Reviewers:
Dan Beam CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, pedrosimonetti+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionCleanup: Remove dead code in NewTabUI
NewTabHTMLSource::resource_map_ was always empty.
BUG=329637
Review-Url: https://codereview.chromium.org/2875943003
Cr-Commit-Position: refs/heads/master@{#471273}
Committed: https://chromium.googlesource.com/chromium/src/+/017e7bdf528cf64351edb9ab815c3ffc67a377bc
Patch Set 1 #
Total comments: 2
Patch Set 2 : review #
Messages
Total messages: 27 (22 generated)
The CQ bit was checked by treib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
treib@chromium.org changed reviewers: + dbeam@chromium.org
PTAL!
Description was changed from ========== Cleanup: Remove dead code in NewTabUI NewTabHTMLSource::resource_map_ was always empty. BUG=none ========== to ========== Cleanup: Remove dead code in NewTabUI NewTabHTMLSource::resource_map_ was always empty. BUG=329637 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2875943003/diff/1/chrome/browser/ui/webui/ntp... File chrome/browser/ui/webui/ntp/new_tab_ui.h (right): https://codereview.chromium.org/2875943003/diff/1/chrome/browser/ui/webui/ntp... chrome/browser/ui/webui/ntp/new_tab_ui.h:8: #include <string> one might argue you could remove this as well...
https://codereview.chromium.org/2875943003/diff/1/chrome/browser/ui/webui/ntp... File chrome/browser/ui/webui/ntp/new_tab_ui.h (right): https://codereview.chromium.org/2875943003/diff/1/chrome/browser/ui/webui/ntp... chrome/browser/ui/webui/ntp/new_tab_ui.h:8: #include <string> On 2017/05/11 17:37:40, Dan Beam wrote: > one might argue you could remove this as well... Because it's only mentioned as part of overridden methods? Eh.. sure, done. [I honestly don't know which way "IWYU" goes in this situation :)]
The CQ bit was checked by treib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by treib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by treib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by treib@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org Link to the patchset: https://codereview.chromium.org/2875943003/#ps20001 (title: "review")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494588876369260,
"parent_rev": "136aeef2b359782047037a3147c8b2a8af6aceda", "commit_rev":
"017e7bdf528cf64351edb9ab815c3ffc67a377bc"}
Message was sent while issue was closed.
Description was changed from ========== Cleanup: Remove dead code in NewTabUI NewTabHTMLSource::resource_map_ was always empty. BUG=329637 ========== to ========== Cleanup: Remove dead code in NewTabUI NewTabHTMLSource::resource_map_ was always empty. BUG=329637 Review-Url: https://codereview.chromium.org/2875943003 Cr-Commit-Position: refs/heads/master@{#471273} Committed: https://chromium.googlesource.com/chromium/src/+/017e7bdf528cf64351edb9ab815c... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/017e7bdf528cf64351edb9ab815c... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
