Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2875933005:
Add README.md doc for WebKit/PerformanceTests/ (Closed)
DescriptionAdd README.md doc for WebKit/PerformanceTests/
This doc explains:
1) How to write WebKit perf tests
2) How to add tracing metrics to a WebKit perf tests
3) How to run the tests
BUG=715344
Review-Url: https://codereview.chromium.org/2875933005
Cr-Commit-Position: refs/heads/master@{#473454}
Committed: https://chromium.googlesource.com/chromium/src/+/1e6feb160d2c37fdcbc9ee9be6e44b5a45705a9d
Patch Set 1 #
Total comments: 34
Patch Set 2 : Address review comments #Messages
Total messages: 20 (13 generated)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
Patchset #1 (id:60001) has been deleted
Description was changed from ========== Add README.md doc for WebKit/PerformanceTests/ ========== to ========== Add README.md doc for WebKit/PerformanceTests/ This doc explains: 1) How to write WebKit/PerformanceTests/ 2) How to add tracing metrics to WebKit/PerformanceTests/ 3) How to run the tests ==========
nednguyen@google.com changed reviewers: + haraken@chromium.org, wangxianzhu@chromium.org
Description was changed from ========== Add README.md doc for WebKit/PerformanceTests/ This doc explains: 1) How to write WebKit/PerformanceTests/ 2) How to add tracing metrics to WebKit/PerformanceTests/ 3) How to run the tests ========== to ========== Add README.md doc for WebKit/PerformanceTests/ This doc explains: 1) How to write WebKit/PerformanceTests/ 2) How to add tracing metrics to WebKit/PerformanceTests/ 3) How to run the tests BUG=715344 ==========
Description was changed from ========== Add README.md doc for WebKit/PerformanceTests/ This doc explains: 1) How to write WebKit/PerformanceTests/ 2) How to add tracing metrics to WebKit/PerformanceTests/ 3) How to run the tests BUG=715344 ========== to ========== Add README.md doc for WebKit/PerformanceTests/ This doc explains: 1) How to write WebKit perf tests 2) How to add tracing metrics to WebKit/PerformanceTests/ 3) How to run the tests BUG=715344 ==========
Description was changed from ========== Add README.md doc for WebKit/PerformanceTests/ This doc explains: 1) How to write WebKit perf tests 2) How to add tracing metrics to WebKit/PerformanceTests/ 3) How to run the tests BUG=715344 ========== to ========== Add README.md doc for WebKit/PerformanceTests/ This doc explains: 1) How to write WebKit perf tests 2) How to add tracing metrics to a WebKit perf tests 3) How to run the tests BUG=715344 ==========
https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... File third_party/WebKit/PerformanceTests/README.md (right): https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:8: is exposed to the Web. They are the the counterpart of [LayoutTests/] "the the" -> "the" https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:14: [runner.js](https://cs.chromium.org/chromium/src/third_party/WebKit/PerformanceTests/resources/runner.js) The url can be relative: resources/runner.js https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:16: [WebKit/PerformanceTests/](https://cs.chromium.org/chromium/src/third_party/WebKit/PerformanceTests/) Ditto. https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:52: When the test in run through Telemetry, you can also collect timing of trace typo "in" https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:81: * CPU times of trace events A: `[v0 + v2, v4, 0.0]` Three spaces after "*", according to https://github.com/google/styleguide/blob/gh-pages/docguide/style.md#nested-l.... https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:122: the test runner & also let the runner now that it has finished a single run. & -> and now -> know? https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:123: One the number of run reaches `iterationCount` (6 in the example above), the One -> Once? https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:124: `done` callback is invoked, allow you to set the your test state to finished. Reword "set the your test ..." https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:134: (`PerfTestRunner.addRunTestEndMarker`). One those are marked, specifying One -> Once? https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:144: viewe won't be supported. typo "viewe" https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:148: ./tools/perf/run_benchmark blink_perf [--test-path=<path to your tests>] Code block quote. https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:151: ./tools/perf/run_benchmark blink_perf --help Code block quote. https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:156: ./third_party/WebKit/Tools/Scripts/run-perf-tests [path to your tets] Code block quote.
LGTM https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... File third_party/WebKit/PerformanceTests/README.md (right): https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:1: # WebKit Performance Tests WebKit => Blink https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:7: WebKit perf tests are used for micro benchmarking the surface of Blink that WebKit => Blink https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:142: Most of WebKit Performance tests should be runnable by just open the test file Ditto. https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:154: ** Running tests through run-perf-tests script ** BTW what's the advantage of keeping run-perf-tests while we have run_benchmark?
https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... File third_party/WebKit/PerformanceTests/README.md (right): https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:1: # WebKit Performance Tests On 2017/05/19 07:57:33, haraken wrote: > > WebKit => Blink Done. https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:7: WebKit perf tests are used for micro benchmarking the surface of Blink that On 2017/05/19 07:57:33, haraken wrote: > > WebKit => Blink Done. https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:8: is exposed to the Web. They are the the counterpart of [LayoutTests/] On 2017/05/19 03:32:10, Xianzhu wrote: > "the the" -> "the" Done. https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:14: [runner.js](https://cs.chromium.org/chromium/src/third_party/WebKit/PerformanceTests/resources/runner.js) On 2017/05/19 03:32:10, Xianzhu wrote: > The url can be relative: resources/runner.js Done. https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:16: [WebKit/PerformanceTests/](https://cs.chromium.org/chromium/src/third_party/WebKit/PerformanceTests/) On 2017/05/19 03:32:10, Xianzhu wrote: > Ditto. I use "." here for current directory. Not sure if this is right :P https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:52: When the test in run through Telemetry, you can also collect timing of trace On 2017/05/19 03:32:10, Xianzhu wrote: > typo "in" Done. https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:81: * CPU times of trace events A: `[v0 + v2, v4, 0.0]` On 2017/05/19 03:32:10, Xianzhu wrote: > Three spaces after "*", according to > https://github.com/google/styleguide/blob/gh-pages/docguide/style.md#nested-l.... Done. https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:122: the test runner & also let the runner now that it has finished a single run. On 2017/05/19 03:32:10, Xianzhu wrote: > & -> and > now -> know? Done. https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:123: One the number of run reaches `iterationCount` (6 in the example above), the On 2017/05/19 03:32:10, Xianzhu wrote: > One -> Once? Done. https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:124: `done` callback is invoked, allow you to set the your test state to finished. On 2017/05/19 03:32:10, Xianzhu wrote: > Reword "set the your test ..." Done. https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:134: (`PerfTestRunner.addRunTestEndMarker`). One those are marked, specifying On 2017/05/19 03:32:10, Xianzhu wrote: > One -> Once? Done. https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:142: Most of WebKit Performance tests should be runnable by just open the test file On 2017/05/19 07:57:33, haraken wrote: > > Ditto. Done. https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:144: viewe won't be supported. On 2017/05/19 03:32:10, Xianzhu wrote: > typo "viewe" Done. https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:148: ./tools/perf/run_benchmark blink_perf [--test-path=<path to your tests>] On 2017/05/19 03:32:10, Xianzhu wrote: > Code block quote. Done. https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:151: ./tools/perf/run_benchmark blink_perf --help On 2017/05/19 03:32:10, Xianzhu wrote: > Code block quote. Done. https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:154: ** Running tests through run-perf-tests script ** On 2017/05/19 07:57:33, haraken wrote: > > BTW what's the advantage of keeping run-perf-tests while we have run_benchmark? We are actually trying to deprecate run-perf-tests. So I will leave out the run-perf-tests instruction for now. https://codereview.chromium.org/2875933005/diff/80001/third_party/WebKit/Perf... third_party/WebKit/PerformanceTests/README.md:156: ./third_party/WebKit/Tools/Scripts/run-perf-tests [path to your tets] On 2017/05/19 03:32:10, Xianzhu wrote: > Code block quote. Removed.
The CQ bit was checked by wangxianzhu@chromium.org
lgtm
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org Link to the patchset: https://codereview.chromium.org/2875933005/#ps100001 (title: "Address review comments")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495317012498210,
"parent_rev": "8c425f992cc443505b84998b0e20330592ff6393", "commit_rev":
"1e6feb160d2c37fdcbc9ee9be6e44b5a45705a9d"}
Message was sent while issue was closed.
Description was changed from ========== Add README.md doc for WebKit/PerformanceTests/ This doc explains: 1) How to write WebKit perf tests 2) How to add tracing metrics to a WebKit perf tests 3) How to run the tests BUG=715344 ========== to ========== Add README.md doc for WebKit/PerformanceTests/ This doc explains: 1) How to write WebKit perf tests 2) How to add tracing metrics to a WebKit perf tests 3) How to run the tests BUG=715344 Review-Url: https://codereview.chromium.org/2875933005 Cr-Commit-Position: refs/heads/master@{#473454} Committed: https://chromium.googlesource.com/chromium/src/+/1e6feb160d2c37fdcbc9ee9be6e4... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:100001) as https://chromium.googlesource.com/chromium/src/+/1e6feb160d2c37fdcbc9ee9be6e4... |
