Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: components/offline_pages/features/features.gni

Issue 2875853003: Add gn args and BUILDFLAGS for OfflinePages, instead on relying on is_android and is_official_build. (Closed)
Patch Set: added files Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/features/features.gni
diff --git a/components/offline_pages/features/features.gni b/components/offline_pages/features/features.gni
new file mode 100644
index 0000000000000000000000000000000000000000..2c8c75b1f4f50b27f7e131fc20ff7cc1e6e2673b
--- /dev/null
+++ b/components/offline_pages/features/features.gni
@@ -0,0 +1,13 @@
+# Copyright 2017 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+declare_args() {
+ # Whether to enable OfflinePages support. Currently user-visible features
+ # are Android-only.
+ enable_offline_pages = is_android
+
+ # This enables test API for locally-built harness which is used for quality
+ # evaluations. Requires setting this variable manually at local environment.
+ enable_offline_pages_harness = false
dewittj 2017/05/11 17:03:40 Probably want to +cc romax and petewil
Dmitry Titov 2017/05/11 17:35:04 Discussed it with romax, adding him as R
romax 2017/05/11 18:09:21 this flag LGTM and I think it's better getting rid
+}
« chrome/browser/android/chrome_jni_registrar.cc ('K') | « components/offline_pages/features/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698