Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Side by Side Diff: components/offline_pages/features/features.gni

Issue 2875853003: Add gn args and BUILDFLAGS for OfflinePages, instead on relying on is_android and is_official_build. (Closed)
Patch Set: added files Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 # Copyright 2017 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
4
5 declare_args() {
6 # Whether to enable OfflinePages support. Currently user-visible features
7 # are Android-only.
8 enable_offline_pages = is_android
9
10 # This enables test API for locally-built harness which is used for quality
11 # evaluations. Requires setting this variable manually at local environment.
12 enable_offline_pages_harness = false
dewittj 2017/05/11 17:03:40 Probably want to +cc romax and petewil
Dmitry Titov 2017/05/11 17:35:04 Discussed it with romax, adding him as R
romax 2017/05/11 18:09:21 this flag LGTM and I think it's better getting rid
13 }
OLDNEW
« chrome/browser/android/chrome_jni_registrar.cc ('K') | « components/offline_pages/features/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698