Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: chrome/browser/subresource_filter/chrome_subresource_filter_client.h

Issue 2875853002: MD Settings: make Subresource Filter exceptions a read-only-list (Closed)
Patch Set: MD Settings: make Subresource Filter exceptions a read-only-list Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/subresource_filter/chrome_subresource_filter_client.h
diff --git a/chrome/browser/subresource_filter/chrome_subresource_filter_client.h b/chrome/browser/subresource_filter/chrome_subresource_filter_client.h
index 8e47d342c9d39f5596ad3f03c25ccf30e1a9b935..d8b3b760f4824f7a0147e678015b163377bf469a 100644
--- a/chrome/browser/subresource_filter/chrome_subresource_filter_client.h
+++ b/chrome/browser/subresource_filter/chrome_subresource_filter_client.h
@@ -58,9 +58,10 @@ enum SubresourceFilterAction {
// A wildcard update. The current content settings API makes this a bit
// difficult to see whether it is Block or Allow. This should not be a huge
// problem because this can only be changed from the settings UI, which is
- // relatively rare.
- // TODO(crbug.com/706061): Fix this once content settings API becomes more
- // flexible.
+ // relatively rare. See crbug.com/706061.
+ //
+ // DEPRECATED: The site settings page uses read-only-lists for exceptions, so
+ // users can't add arbitrary patterns.
kActionContentSettingsWildcardUpdate,
// The UI was suppressed due to "smart" logic which tries not to spam the UI
« no previous file with comments | « chrome/browser/resources/settings/privacy_page/privacy_page.html ('k') | tools/metrics/histograms/enums.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698