Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2875853002: MD Settings: make Subresource Filter exceptions a read-only-list (Closed)

Created:
3 years, 7 months ago by Charlie Harrison
Modified:
3 years, 7 months ago
Reviewers:
tommycli, raymes
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: make Subresource Filter exceptions a read-only-list BUG=689487 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2875853002 Cr-Commit-Position: refs/heads/master@{#471854} Committed: https://chromium.googlesource.com/chromium/src/+/b5be4e3d0ac15fb087cf1cb63d29d3584ab8a6e9

Patch Set 1 #

Patch Set 2 : MD Settings: make Subresource Filter exceptions a read-only-list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/subresource_filter/chrome_subresource_filter_client.h View 1 1 chunk +4 lines, -3 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Charlie Harrison
tommycli, raymes: PTAL?
3 years, 7 months ago (2017-05-11 15:52:07 UTC) #5
raymes
I defer to tommycli who knows the code better than me. Thanks for doing this ...
3 years, 7 months ago (2017-05-14 22:44:56 UTC) #6
tommycli
lgtm assuming subresource filter should indeed be read-only in Settings. Thanks!
3 years, 7 months ago (2017-05-15 17:15:45 UTC) #7
Charlie Harrison
Yeah, we want the ability to only remove entries, which I've confirmed still works with ...
3 years, 7 months ago (2017-05-15 17:17:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875853002/20001
3 years, 7 months ago (2017-05-15 17:17:33 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 19:05:15 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b5be4e3d0ac15fb087cf1cb63d29...

Powered by Google App Engine
This is Rietveld 408576698