Convert ozone/drm to OnceCallback

Convert ozone/drm to OnceCallback

As a helpful prerequisite to the addition of mojo IPC in ozone/drm,
use base::OnceCallback in place of base::Callback for all non swap
callbacks.

BUG=620927
Review-Url: https://codereview.chromium.org/2875823005
Cr-Commit-Position: refs/heads/master@{#471769}
Committed: https://chromium.googlesource.com/chromium/src/+/2421ee1aeb0c71573527fd33145ce1e0b18a9888

[rjkroege, 2017-05-12 14:09:39]

rjkroege@chromium.org changed reviewers:
+ dnicoara@chromium.org

[rjkroege, 2017-05-12 14:09:40]

ptal

[dnicoara, 2017-05-12 14:35:25]

Your previous CL adding CreateSafeOnceCallback was reverted for failing
unittests.

https://codereview.chromium.org/2875823005/diff/1/ui/ozone/platform/drm/gpu/d...
File ui/ozone/platform/drm/gpu/drm_thread.cc (right):

https://codereview.chromium.org/2875823005/diff/1/ui/ozone/platform/drm/gpu/d...
ui/ozone/platform/drm/gpu/drm_thread.cc:223: std::move(callback).Run(
Just wondering why does the callback need to be moved?

[rjkroege, 2017-05-12 19:37:12]

On 2017/05/12 14:35:25, dnicoara wrote:
> Your previous CL adding CreateSafeOnceCallback was reverted for failing
> unittests.

I know. And now fixed. The test would fail with dchecks off. Revised version in
CQ.

> 
>
https://codereview.chromium.org/2875823005/diff/1/ui/ozone/platform/drm/gpu/d...
> File ui/ozone/platform/drm/gpu/drm_thread.cc (right):
> 
>
https://codereview.chromium.org/2875823005/diff/1/ui/ozone/platform/drm/gpu/d...
> ui/ozone/platform/drm/gpu/drm_thread.cc:223: std::move(callback).Run(
> Just wondering why does the callback need to be moved?

Since the receiver (this) is a move-only type, we can't keep a copy of it in
both the caller and Run() itself. Instead, we have to std::move the unique
instance it into Run. (See
https://cs.chromium.org/chromium/src/docs/callback.md?q=cs+OnceCallback&dr=C&...).

[dnicoara, 2017-05-12 19:43:11]

lgtm


On 2017/05/12 19:37:12, rjkroege wrote:
> On 2017/05/12 14:35:25, dnicoara wrote:
> > Your previous CL adding CreateSafeOnceCallback was reverted for failing
> > unittests.
> 
> I know. And now fixed. The test would fail with dchecks off. Revised version
in
> CQ.
> 
> > 
> >
>
https://codereview.chromium.org/2875823005/diff/1/ui/ozone/platform/drm/gpu/d...
> > File ui/ozone/platform/drm/gpu/drm_thread.cc (right):
> > 
> >
>
https://codereview.chromium.org/2875823005/diff/1/ui/ozone/platform/drm/gpu/d...
> > ui/ozone/platform/drm/gpu/drm_thread.cc:223: std::move(callback).Run(
> > Just wondering why does the callback need to be moved?
> 
> Since the receiver (this) is a move-only type, we can't keep a copy of it in
> both the caller and Run() itself. Instead, we have to std::move the unique
> instance it into Run. (See
>
https://cs.chromium.org/chromium/src/docs/callback.md?q=cs+OnceCallback&dr=C&...).

Oh, I see, thanks!

[rjkroege, 2017-05-15 14:28:08]

The CQ bit was checked by rjkroege@chromium.org

[rjkroege, 2017-05-15 14:28:13]

The CQ bit was unchecked by rjkroege@chromium.org

[rjkroege, 2017-05-15 14:38:43]

The CQ bit was checked by rjkroege@chromium.org

[commit-bot: I haz the power, 2017-05-15 14:39:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 15:15:06]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494859123828630, "parent_rev":
"3b795e6c6dad770282dc2a08d68b515bb59dc8ff", "commit_rev":
"2421ee1aeb0c71573527fd33145ce1e0b18a9888"}

[commit-bot: I haz the power, 2017-05-15 15:15:16]

Description was changed from

==========
Convert ozone/drm to OnceCallback

As a helpful prerequisite to the addition of mojo IPC in ozone/drm,
use base::OnceCallback in place of base::Callback for all non swap
callbacks.

BUG=620927
==========

to

==========
Convert ozone/drm to OnceCallback

As a helpful prerequisite to the addition of mojo IPC in ozone/drm,
use base::OnceCallback in place of base::Callback for all non swap
callbacks.

BUG=620927

Review-Url: https://codereview.chromium.org/2875823005
Cr-Commit-Position: refs/heads/master@{#471769}
Committed:
https://chromium.googlesource.com/chromium/src/+/2421ee1aeb0c71573527fd33145c...
==========

[commit-bot: I haz the power, 2017-05-15 15:15:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2421ee1aeb0c71573527fd33145c...