Add experimental private memory footprint metrics.

Add experimental private memory footprint metrics for macOS.

These metrics are temporary and are intended to be removed once the same metrics
are emitted by the memory instrumentation service.

BUG=720541
Review-Url: https://codereview.chromium.org/2875823004
Cr-Commit-Position: refs/heads/master@{#471107}
Committed: https://chromium.googlesource.com/chromium/src/+/4abfe94b81096ee4c806240b0ea5e2c03bfe4b65

[erikchen, 2017-05-11 19:27:28]

Description was changed from

==========
Add experimental metrics.

BUG=
==========

to

==========
Add experimental private memory footprint metrics.

These metrics are temporary and are intended to be removed once the same metrics
are emitted by the memory instrumentation service.

BUG=720541
==========

[erikchen, 2017-05-11 19:27:32]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 19:28:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 19:46:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 19:46:40]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[erikchen, 2017-05-11 20:09:20]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[erikchen, 2017-05-11 20:09:29]

Description was changed from

==========
Add experimental private memory footprint metrics.

These metrics are temporary and are intended to be removed once the same metrics
are emitted by the memory instrumentation service.

BUG=720541
==========

to

==========
Add experimental private memory footprint metrics for macOS.

These metrics are temporary and are intended to be removed once the same metrics
are emitted by the memory instrumentation service.

BUG=720541
==========

[erikchen, 2017-05-11 20:10:15]

erikchen@chromium.org changed reviewers:
+ rkaplow@chromium.org, thakis@chromium.org

[erikchen, 2017-05-11 20:10:16]

thakis: Please review chrome.
rkaplow: Please review *histograms*

[commit-bot: I haz the power, 2017-05-11 20:10:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[erikchen, 2017-05-11 20:11:00]

On 2017/05/11 20:10:16, erikchen wrote:
> thakis: Please review chrome.
> rkaplow: Please review *histograms*

For context: we really want these metrics for memory convergence 3, but the
memory instrumentation version probably won't be ready before that, so I'm
adding some very temporary stats.

[Nico, 2017-05-11 20:12:59]

https://codereview.chromium.org/2875823004/diff/20001/chrome/browser/memory_d...
File chrome/browser/memory_details_mac.cc (right):

https://codereview.chromium.org/2875823004/diff/20001/chrome/browser/memory_d...
chrome/browser/memory_details_mac.cc:72: info.private_memory_footprint =
vm_info.phys_footprint;
are you sure that you want to send differently computed things on different OS?
This means this metric will be useless to look at unless you split by os.

[erikchen, 2017-05-11 21:02:22]

https://codereview.chromium.org/2875823004/diff/20001/chrome/browser/memory_d...
File chrome/browser/memory_details_mac.cc (right):

https://codereview.chromium.org/2875823004/diff/20001/chrome/browser/memory_d...
chrome/browser/memory_details_mac.cc:72: info.private_memory_footprint =
vm_info.phys_footprint;
On 2017/05/11 20:12:59, Nico wrote:
> are you sure that you want to send differently computed things on different
OS?
> This means this metric will be useless to look at unless you split by os.

Yup. The first API is strictly better, but not available on older OSes. This is
an experimental, temporary metric and I'll remember to split.

When we do this officially, we probably will want to have separately named UMA
metrics to avoid confusion.

[Nico, 2017-05-11 21:04:25]

*shrug* lgtm. Temporary code never sticks around…

[rkaplow, 2017-05-11 21:31:22]

lgtm

[erikchen, 2017-05-11 21:32:44]

The CQ bit was unchecked by erikchen@chromium.org

[erikchen, 2017-05-11 21:32:45]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2017-05-11 21:34:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 23:05:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494538365149540,
"parent_rev": "6566c8ac694b25ca9a5a14266fce59b2c9b5ede4", "commit_rev":
"4abfe94b81096ee4c806240b0ea5e2c03bfe4b65"}

[commit-bot: I haz the power, 2017-05-11 23:06:06]

Description was changed from

==========
Add experimental private memory footprint metrics for macOS.

These metrics are temporary and are intended to be removed once the same metrics
are emitted by the memory instrumentation service.

BUG=720541
==========

to

==========
Add experimental private memory footprint metrics for macOS.

These metrics are temporary and are intended to be removed once the same metrics
are emitted by the memory instrumentation service.

BUG=720541

Review-Url: https://codereview.chromium.org/2875823004
Cr-Commit-Position: refs/heads/master@{#471107}
Committed:
https://chromium.googlesource.com/chromium/src/+/4abfe94b81096ee4c806240b0ea5...
==========

[commit-bot: I haz the power, 2017-05-11 23:06:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4abfe94b81096ee4c806240b0ea5...