Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2875823002: Add vpython support to Python recipe module. (Closed)

Created:
3 years, 7 months ago by dnj
Modified:
3 years, 7 months ago
Reviewers:
dnj (Google), iannucci
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add vpython support to Python recipe module. Add a keyword argument to the Python recipe module's "__call__" method that can be used to configure the VirtualEnv under which the module is run. BUG=None TEST=expectations Review-Url: https://codereview.chromium.org/2875823002 Committed: https://github.com/luci/recipes-py/commit/60cc7f3f49737e8cf852e396b4436c2b6bd3f56d

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments #

Patch Set 3 : more comments and debuggin #

Patch Set 4 : rebase #

Messages

Total messages: 28 (22 generated)
dnj (Google)
PTAL
3 years, 7 months ago (2017-05-10 21:53:13 UTC) #2
iannucci
lgtm https://codereview.chromium.org/2875823002/diff/1/recipe_modules/python/api.py File recipe_modules/python/api.py (right): https://codereview.chromium.org/2875823002/diff/1/recipe_modules/python/api.py#newcode17 recipe_modules/python/api.py:17: script (str): The name of the script to ...
3 years, 7 months ago (2017-05-10 22:46:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875823002/20001
3 years, 7 months ago (2017-05-10 22:59:34 UTC) #6
iannucci
let's land this tomorrow?
3 years, 7 months ago (2017-05-12 07:53:35 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875823002/60001
3 years, 7 months ago (2017-05-12 15:57:59 UTC) #25
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 16:00:52 UTC) #28
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://github.com/luci/recipes-py/commit/60cc7f3f49737e8cf852e396b4436c2b6bd...

Powered by Google App Engine
This is Rietveld 408576698