Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2875813002: [Chrome Home] Fix/disable two tests (Closed)

Created:
3 years, 7 months ago by Theresa
Modified:
3 years, 7 months ago
Reviewers:
mdjones
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chrome Home] Fix/disable two tests Fix BottomSheetContentControllerTest#testSelectContent() and disable ChromeHomeNewTabPageTest#testCloseNTP_OneTab. BUG=720633, 720637, 719972 TBR=dgn@chromium.org Review-Url: https://codereview.chromium.org/2875813002 Cr-Commit-Position: refs/heads/master@{#470799} Committed: https://chromium.googlesource.com/chromium/src/+/8365207b95d1670fe7a750fed1bb9703bdf411b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageTest.java View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentControllerTest.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Theresa
ptal
3 years, 7 months ago (2017-05-10 21:36:44 UTC) #3
mdjones
lgtm
3 years, 7 months ago (2017-05-10 23:31:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875813002/1
3 years, 7 months ago (2017-05-10 23:32:12 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 03:57:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8365207b95d1670fe7a750fed1bb...

Powered by Google App Engine
This is Rietveld 408576698