Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2875803002: Deprecated WebStateObserver::NavigationItemChanged. (Closed)

Created:
3 years, 7 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 7 months ago
Reviewers:
michaeldo
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecated WebStateObserver::NavigationItemChanged. BUG=720786 Review-Url: https://codereview.chromium.org/2875803002 Cr-Commit-Position: refs/heads/master@{#470745} Committed: https://chromium.googlesource.com/chromium/src/+/6c4024f15794934a9f99a1d1dae4cad29ed9124c

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ios/web/public/web_state/web_state_observer.h View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Eugene But (OOO till 7-30)
3 years, 7 months ago (2017-05-10 21:22:44 UTC) #2
michaeldo
lgtm https://codereview.chromium.org/2875803002/diff/1/ios/web/public/web_state/web_state_observer.h File ios/web/public/web_state/web_state_observer.h (right): https://codereview.chromium.org/2875803002/diff/1/ios/web/public/web_state/web_state_observer.h#newcode44 ios/web/public/web_state/web_state_observer.h:44: // DidFinishNavigation for |window.location.replace|. s / DidFinishNavigation / ...
3 years, 7 months ago (2017-05-10 21:54:07 UTC) #4
Eugene But (OOO till 7-30)
https://codereview.chromium.org/2875803002/diff/1/ios/web/public/web_state/web_state_observer.h File ios/web/public/web_state/web_state_observer.h (right): https://codereview.chromium.org/2875803002/diff/1/ios/web/public/web_state/web_state_observer.h#newcode44 ios/web/public/web_state/web_state_observer.h:44: // DidFinishNavigation for |window.location.replace|. On 2017/05/10 21:54:06, michaeldo wrote: ...
3 years, 7 months ago (2017-05-10 22:53:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875803002/20001
3 years, 7 months ago (2017-05-10 22:55:20 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 23:29:17 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6c4024f15794934a9f99a1d1dae4...

Powered by Google App Engine
This is Rietveld 408576698