Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2875793003: Summarize platform sensor support in device/generic_sensor/README.md (Closed)

Created:
3 years, 7 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 7 months ago
Reviewers:
scheib
CC:
chromium-reviews, wanming.lin, shalamov, Mikhail
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Summarize platform sensor support in device/generic_sensor/README.md This patch adds a table to device/generic_sensor/README.md which documents the support matrix for the various sensor types exposed by this service's public Mojo interface and how they map to the sensor APIs on each platform. BUG=None Review-Url: https://codereview.chromium.org/2875793003 Cr-Commit-Position: refs/heads/master@{#470749} Committed: https://chromium.googlesource.com/chromium/src/+/690014d5daded3c46b14ada29ab40a04f24d4b51

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove redundant language #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M device/generic_sensor/README.md View 1 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Reilly Grant (use Gerrit)
PTAL
3 years, 7 months ago (2017-05-10 22:58:31 UTC) #2
scheib
LGTM, but suggestion: https://codereview.chromium.org/2875793003/diff/1/device/generic_sensor/README.md File device/generic_sensor/README.md (right): https://codereview.chromium.org/2875793003/diff/1/device/generic_sensor/README.md#newcode30 device/generic_sensor/README.md:30: On Android sensors are implemented by ...
3 years, 7 months ago (2017-05-10 23:08:34 UTC) #5
Reilly Grant (use Gerrit)
Remove redundant language
3 years, 7 months ago (2017-05-10 23:13:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875793003/20001
3 years, 7 months ago (2017-05-10 23:15:40 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 23:40:56 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/690014d5daded3c46b14ada29ab4...

Powered by Google App Engine
This is Rietveld 408576698