Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2875783002:
Add tools/perf/blink_perf_cmdline/OWNERS (Closed)
DescriptionAdd tools/perf/blink_perf_cmdline/OWNERS
This directory is for creating a new blink_perf benchmark that allows users
to run arbitrary blink_perf test paths through Telemetry
BUG=chromium:720772
Review-Url: https://codereview.chromium.org/2875783002
Cr-Commit-Position: refs/heads/master@{#470999}
Committed: https://chromium.googlesource.com/chromium/src/+/42e64aa07b0c14272ec351517ef75acc9a946a38
Patch Set 1 #
Messages
Total messages: 18 (10 generated)
nednguyen@google.com changed reviewers: + charliea@chromium.org, wangxianzhu@chromium.org
The CQ bit was checked by nednguyen@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
On 2017/05/10 23:06:41, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started once the patch has received an L-G-T-M from a full > committer. > Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a > full super star committer. > Committers are members of the group "project-chromium-committers". > Note that this has nothing to do with OWNERS files. Ping
lgtm
On 2017/05/11 16:40:19, charliea wrote: > lgtm Chatted offline, Xianzhu is ok with being a maintainer of this, so I am landing this CL.
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494521040955180, "parent_rev":
"36e1180ea36f550e282471294a3cbae9a17053ba", "commit_rev":
"42e64aa07b0c14272ec351517ef75acc9a946a38"}
Message was sent while issue was closed.
Description was changed from ========== Add tools/perf/blink_perf_cmdline/OWNERS This directory is for creating a new blink_perf benchmark that allows users to run arbitrary blink_perf test paths through Telemetry BUG=chromium:720772 ========== to ========== Add tools/perf/blink_perf_cmdline/OWNERS This directory is for creating a new blink_perf benchmark that allows users to run arbitrary blink_perf test paths through Telemetry BUG=chromium:720772 Review-Url: https://codereview.chromium.org/2875783002 Cr-Commit-Position: refs/heads/master@{#470999} Committed: https://chromium.googlesource.com/chromium/src/+/42e64aa07b0c14272ec351517ef7... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/42e64aa07b0c14272ec351517ef7... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
