Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2875763002:
Prune ComputeVisibleSelectionInDOMTreeDeprecated from FrameSelection::CurrentForm (Closed)
|
Created:
3 years, 7 months ago by Xiaocheng Modified:
3 years, 7 months ago Reviewers:
yosin_UTC9 CC:
blink-reviews, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionPrune ComputeVisibleSelectionInDOMTreeDeprecated from FrameSelection::CurrentForm
This patch prunes a call site of the deprecated function, which is safe
because the call site is reachable only from
ContextMenuClientImpl::ShowContextMenu, where layout has been updated
due to a hit test.
BUG=698633
TEST=n/a; no behavioral changes.
Review-Url: https://codereview.chromium.org/2875763002
Cr-Commit-Position: refs/heads/master@{#471495}
Committed: https://chromium.googlesource.com/chromium/src/+/1e9f052d41ee97a500751f34995d701c7a83cc4f
Patch Set 1 #
Messages
Total messages: 37 (25 generated)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Description was changed from ========== Prune ComputeVisibleSelectionInDOMTreeDeprecated from FrameSelection::CurrentForm BUG= ========== to ========== Prune ComputeVisibleSelectionInDOMTreeDeprecated from FrameSelection::CurrentForm This patch prunes a call site of the deprecated function, which is safe because the call site is reachable only from ContextMenuClientImpl::ShowContextMenu, where layout has been updated due to a hit test. BUG=698633 TEST=n/a; no behavioral changes. ==========
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
xiaochengh@chromium.org changed reviewers: + yosin@chromium.org
PTAL.
The CQ bit was checked by yosin@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by xiaochengh@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by xiaochengh@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494632285923850, "parent_rev":
"4838cef544c67d342c418d208e52cd8a4cf1a3d2", "commit_rev":
"1e9f052d41ee97a500751f34995d701c7a83cc4f"}
Message was sent while issue was closed.
Description was changed from ========== Prune ComputeVisibleSelectionInDOMTreeDeprecated from FrameSelection::CurrentForm This patch prunes a call site of the deprecated function, which is safe because the call site is reachable only from ContextMenuClientImpl::ShowContextMenu, where layout has been updated due to a hit test. BUG=698633 TEST=n/a; no behavioral changes. ========== to ========== Prune ComputeVisibleSelectionInDOMTreeDeprecated from FrameSelection::CurrentForm This patch prunes a call site of the deprecated function, which is safe because the call site is reachable only from ContextMenuClientImpl::ShowContextMenu, where layout has been updated due to a hit test. BUG=698633 TEST=n/a; no behavioral changes. Review-Url: https://codereview.chromium.org/2875763002 Cr-Commit-Position: refs/heads/master@{#471495} Committed: https://chromium.googlesource.com/chromium/src/+/1e9f052d41ee97a500751f34995d... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1e9f052d41ee97a500751f34995d... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
