Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2875743002: Change disabled CTS test (Closed)

Created:
3 years, 7 months ago by the real yoland
Modified:
3 years, 7 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M android_webview/tools/cts_config/expected_failure_on_bot.json View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875743002/1
3 years, 7 months ago (2017-05-10 18:22:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e50ed3b9e1a96c042dddb7e14d0a7ef40e19ce3d
3 years, 7 months ago (2017-05-10 18:43:59 UTC) #5
timvolodine
https://codereview.chromium.org/2875743002/diff/1/android_webview/tools/cts_config/expected_failure_on_bot.json File android_webview/tools/cts_config/expected_failure_on_bot.json (right): https://codereview.chromium.org/2875743002/diff/1/android_webview/tools/cts_config/expected_failure_on_bot.json#newcode26 android_webview/tools/cts_config/expected_failure_on_bot.json:26: "name": "testOnJsBeforeUnloadIsCalled", hmm, why is this changed exactly?
3 years, 7 months ago (2017-05-11 18:08:37 UTC) #7
the real yoland
3 years, 7 months ago (2017-05-11 19:04:12 UTC) #8
Message was sent while issue was closed.
On 2017/05/11 at 18:08:37, timvolodine wrote:
>
https://codereview.chromium.org/2875743002/diff/1/android_webview/tools/cts_c...
> File android_webview/tools/cts_config/expected_failure_on_bot.json (right):
> 
>
https://codereview.chromium.org/2875743002/diff/1/android_webview/tools/cts_c...
> android_webview/tools/cts_config/expected_failure_on_bot.json:26: "name":
"testOnJsBeforeUnloadIsCalled",
> hmm, why is this changed exactly?

It was wrongly put at the first place :(

testWebViewIncludedStableInterfaces is not the CTS's name, it's the
LayoutShellTest's name

Sorry, I wasn't very clear on the CL message

Powered by Google App Engine
This is Rietveld 408576698