Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2875703003: Rewrite two more classes to new blink style. (Closed)

Created:
3 years, 7 months ago by Nico
Modified:
3 years, 7 months ago
Reviewers:
dcheng
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, fmalita+watch_chromium.org, Rik, Justin Novosad, blink-reviews, piman+watch_chromium.org, kinuko+watch, Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite three more classes to new blink style. No behavior change. BUG=675877 Review-Url: https://codereview.chromium.org/2875703003 Cr-Commit-Position: refs/heads/master@{#471044} Committed: https://chromium.googlesource.com/chromium/src/+/67d309c494ff65745c436e46e4ed7c3095b07d8a

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -44 lines) Patch
M third_party/WebKit/Source/platform/fonts/VDMXParser.cpp View 1 8 chunks +33 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContextTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/skia/SkiaUtils.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/test/FakeGLES2Interface.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 33 (18 generated)
Nico
3 years, 7 months ago (2017-05-10 16:54:48 UTC) #3
dcheng
LGTM Btw, are you doing these by hand? Or just running the tool on a ...
3 years, 7 months ago (2017-05-10 16:57:03 UTC) #5
Nico
On 2017/05/10 16:57:03, dcheng wrote: > LGTM > > Btw, are you doing these by ...
3 years, 7 months ago (2017-05-10 17:02:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875703003/1
3 years, 7 months ago (2017-05-10 17:05:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/449985)
3 years, 7 months ago (2017-05-10 17:29:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875703003/20001
3 years, 7 months ago (2017-05-10 17:38:08 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450526)
3 years, 7 months ago (2017-05-10 19:59:02 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875703003/20001
3 years, 7 months ago (2017-05-10 20:11:18 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450777)
3 years, 7 months ago (2017-05-10 22:26:48 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875703003/20001
3 years, 7 months ago (2017-05-11 13:28:14 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/451784)
3 years, 7 months ago (2017-05-11 15:22:59 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875703003/20001
3 years, 7 months ago (2017-05-11 15:24:39 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/451913)
3 years, 7 months ago (2017-05-11 17:15:59 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875703003/20001
3 years, 7 months ago (2017-05-11 17:25:10 UTC) #30
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 19:35:11 UTC) #33
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/67d309c494ff65745c436e46e4ed...

Powered by Google App Engine
This is Rietveld 408576698