Move "id" from KeyframeEffectOptions to KeyframeAnimationOptions and

Move "id" from KeyframeEffectOptions to KeyframeAnimationOptions and
change ElementAnimtaions to take KeyframeAnimationOptions as arg.

See https://w3c.github.io/web-animations/#dictdef-keyframeanimationoptions

NOTE: this IDL change doesn't affect out shipping behaviour, and has low compatibility risk. Hence there is no need for an intent-to-ship notification.

Blink currently deviates from the spec in that the "id" field should be
in KeyframeAnimationOptions instead of KeyframeEffectOptions. Interface
Element should also take KeyframeAnimationOptions as arg. This cl
contains the following changes
- Add a new KeyframeAnimationOptions interface.
- Move "id" from KeyframeEffectOptions to KeyframeAnimationOptions.
- Change ElementAnimations to take KeyframeAnimationOptions as arg.
- Updates TimingInput to support KeyframeAnimationOptions.
- Add unit tests for TimingInput to cover KeyframeAnimationOptions.

BUG=700267
Review-Url: https://codereview.chromium.org/2875673005
Cr-Commit-Position: refs/heads/master@{#471164}
Committed: https://chromium.googlesource.com/chromium/src/+/84b6a842c0d92a52a557dbe102a9787999dfff21

[Jia, 2017-05-11 04:37:51]

Description was changed from

==========
Move "id" from KeyframeEffectOptions to KeyframeAnimationOptions and
change ElementAnimtaions to take KeyframeAnimationOptions as arg.

Blink currently deviates from the spec in that the "id" field should be
in KeyframeAnimationOptions instead of KeyframeEffectOptions. Interface
Element should also take KeyframeAnimationOptions as arg. This cl
contains the following changes
- Adds a new KeyframeAnimationOptions.idl.
- Moves "id" from KeyframeEffectOptions to KeyframeAnimationOptions.
- Changes ElementAnimations to take KeyframeAnimationOptions as arg.
- Updates TimingInput to support KeyframeAnimationOptions.

BUG=700267
==========

to

==========
Move "id" from KeyframeEffectOptions to KeyframeAnimationOptions and
change ElementAnimtaions to take KeyframeAnimationOptions as arg.

Blink currently deviates from the spec in that the "id" field should be
in KeyframeAnimationOptions instead of KeyframeEffectOptions. Interface
Element should also take KeyframeAnimationOptions as arg. This cl
contains the following changes
- Add a new KeyframeAnimationOptions interface.
- Move "id" from KeyframeEffectOptions to KeyframeAnimationOptions.
- Change ElementAnimations to take KeyframeAnimationOptions as arg.
- Updates TimingInput to support KeyframeAnimationOptions.
- Add unit tests for TimingInput to cover KeyframeAnimationOptions.

BUG=700267
==========

[Jia, 2017-05-11 04:38:09]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[Jia, 2017-05-11 04:38:46]

jiameng@chromium.org changed reviewers:
+ alancutter@chromium.org

[commit-bot: I haz the power, 2017-05-11 04:39:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alancutter (OOO until 2018), 2017-05-11 05:45:38]

The description should link to the section of the spec that this patch is
conforming to.

[alancutter (OOO until 2018), 2017-05-11 05:52:06]

lgtm

[Jia, 2017-05-11 06:10:43]

Description was changed from

==========
Move "id" from KeyframeEffectOptions to KeyframeAnimationOptions and
change ElementAnimtaions to take KeyframeAnimationOptions as arg.

Blink currently deviates from the spec in that the "id" field should be
in KeyframeAnimationOptions instead of KeyframeEffectOptions. Interface
Element should also take KeyframeAnimationOptions as arg. This cl
contains the following changes
- Add a new KeyframeAnimationOptions interface.
- Move "id" from KeyframeEffectOptions to KeyframeAnimationOptions.
- Change ElementAnimations to take KeyframeAnimationOptions as arg.
- Updates TimingInput to support KeyframeAnimationOptions.
- Add unit tests for TimingInput to cover KeyframeAnimationOptions.

BUG=700267
==========

to

==========
Move "id" from KeyframeEffectOptions to KeyframeAnimationOptions and
change ElementAnimtaions to take KeyframeAnimationOptions as arg.

See https://w3c.github.io/web-animations/#dictdef-keyframeanimationoptions

Blink currently deviates from the spec in that the "id" field should be
in KeyframeAnimationOptions instead of KeyframeEffectOptions. Interface
Element should also take KeyframeAnimationOptions as arg. This cl
contains the following changes
- Add a new KeyframeAnimationOptions interface.
- Move "id" from KeyframeEffectOptions to KeyframeAnimationOptions.
- Change ElementAnimations to take KeyframeAnimationOptions as arg.
- Updates TimingInput to support KeyframeAnimationOptions.
- Add unit tests for TimingInput to cover KeyframeAnimationOptions.

BUG=700267
==========

[Jia, 2017-05-11 06:11:08]

On 2017/05/11 05:45:38, alancutter wrote:
> The description should link to the section of the spec that this patch is
> conforming to.

Thanks! All done.

[Jia, 2017-05-11 06:12:43]

jiameng@chromium.org changed reviewers:
+ haraken@chromium.org

[Jia, 2017-05-11 06:16:22]

jiameng@chromium.org changed reviewers:
+ suzyh@chromium.org

[commit-bot: I haz the power, 2017-05-11 08:35:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 08:35:21]

Dry run: This issue passed the CQ dry run.

[haraken, 2017-05-12 00:34:12]

LGTM

However for the IDL change I think it would be better to get an approval from an
API owner.

[Jia, 2017-05-12 00:42:23]

jiameng@chromium.org changed reviewers:
+ tkent@chromium.org
- suzyh@chromium.org

[tkent, 2017-05-12 00:51:10]

lgtm as an API owner.
Compatibility risk is very low, and intent-to-ship isn't necessary IMO.

[alancutter (OOO until 2018), 2017-05-12 00:52:03]

On 2017/05/12 at 00:34:12, haraken wrote:
> LGTM
> 
> However for the IDL change I think it would be better to get an approval from
an API owner.

This IDL change doesn't affect out shipping behaviour. This should probably be
mentioned in the description.

[Jia, 2017-05-12 00:56:44]

Description was changed from

==========
Move "id" from KeyframeEffectOptions to KeyframeAnimationOptions and
change ElementAnimtaions to take KeyframeAnimationOptions as arg.

See https://w3c.github.io/web-animations/#dictdef-keyframeanimationoptions

Blink currently deviates from the spec in that the "id" field should be
in KeyframeAnimationOptions instead of KeyframeEffectOptions. Interface
Element should also take KeyframeAnimationOptions as arg. This cl
contains the following changes
- Add a new KeyframeAnimationOptions interface.
- Move "id" from KeyframeEffectOptions to KeyframeAnimationOptions.
- Change ElementAnimations to take KeyframeAnimationOptions as arg.
- Updates TimingInput to support KeyframeAnimationOptions.
- Add unit tests for TimingInput to cover KeyframeAnimationOptions.

BUG=700267
==========

to

==========
Move "id" from KeyframeEffectOptions to KeyframeAnimationOptions and
change ElementAnimtaions to take KeyframeAnimationOptions as arg.

See https://w3c.github.io/web-animations/#dictdef-keyframeanimationoptions

NOTE: this IDL change doesn't affect out shipping behaviour, and has low
compatibility risk. Hence there is no need for an intent-to-ship notification.

Blink currently deviates from the spec in that the "id" field should be
in KeyframeAnimationOptions instead of KeyframeEffectOptions. Interface
Element should also take KeyframeAnimationOptions as arg. This cl
contains the following changes
- Add a new KeyframeAnimationOptions interface.
- Move "id" from KeyframeEffectOptions to KeyframeAnimationOptions.
- Change ElementAnimations to take KeyframeAnimationOptions as arg.
- Updates TimingInput to support KeyframeAnimationOptions.
- Add unit tests for TimingInput to cover KeyframeAnimationOptions.

BUG=700267
==========

[Jia, 2017-05-12 00:57:04]

On 2017/05/12 00:52:03, alancutter wrote:
> On 2017/05/12 at 00:34:12, haraken wrote:
> > LGTM
> > 
> > However for the IDL change I think it would be better to get an approval
from
> an API owner.
> 
> This IDL change doesn't affect out shipping behaviour. This should probably be
> mentioned in the description.

Thanks! I've added this comment in the description.

[Jia, 2017-05-12 00:58:39]

Thanks for all your reviews. I'll submit the cl shortly.

[Jia, 2017-05-12 01:09:41]

The CQ bit was checked by jiameng@chromium.org

[commit-bot: I haz the power, 2017-05-12 01:10:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 01:23:21]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494551381429230,
"parent_rev": "eeebb4ab4b1838d33b73e1eb9370ec11313c1ee6", "commit_rev":
"84b6a842c0d92a52a557dbe102a9787999dfff21"}

[commit-bot: I haz the power, 2017-05-12 01:23:30]

Description was changed from

==========
Move "id" from KeyframeEffectOptions to KeyframeAnimationOptions and
change ElementAnimtaions to take KeyframeAnimationOptions as arg.

See https://w3c.github.io/web-animations/#dictdef-keyframeanimationoptions

NOTE: this IDL change doesn't affect out shipping behaviour, and has low
compatibility risk. Hence there is no need for an intent-to-ship notification.

Blink currently deviates from the spec in that the "id" field should be
in KeyframeAnimationOptions instead of KeyframeEffectOptions. Interface
Element should also take KeyframeAnimationOptions as arg. This cl
contains the following changes
- Add a new KeyframeAnimationOptions interface.
- Move "id" from KeyframeEffectOptions to KeyframeAnimationOptions.
- Change ElementAnimations to take KeyframeAnimationOptions as arg.
- Updates TimingInput to support KeyframeAnimationOptions.
- Add unit tests for TimingInput to cover KeyframeAnimationOptions.

BUG=700267
==========

to

==========
Move "id" from KeyframeEffectOptions to KeyframeAnimationOptions and
change ElementAnimtaions to take KeyframeAnimationOptions as arg.

See https://w3c.github.io/web-animations/#dictdef-keyframeanimationoptions

NOTE: this IDL change doesn't affect out shipping behaviour, and has low
compatibility risk. Hence there is no need for an intent-to-ship notification.

Blink currently deviates from the spec in that the "id" field should be
in KeyframeAnimationOptions instead of KeyframeEffectOptions. Interface
Element should also take KeyframeAnimationOptions as arg. This cl
contains the following changes
- Add a new KeyframeAnimationOptions interface.
- Move "id" from KeyframeEffectOptions to KeyframeAnimationOptions.
- Change ElementAnimations to take KeyframeAnimationOptions as arg.
- Updates TimingInput to support KeyframeAnimationOptions.
- Add unit tests for TimingInput to cover KeyframeAnimationOptions.

BUG=700267

Review-Url: https://codereview.chromium.org/2875673005
Cr-Commit-Position: refs/heads/master@{#471164}
Committed:
https://chromium.googlesource.com/chromium/src/+/84b6a842c0d92a52a557dbe102a9...
==========

[commit-bot: I haz the power, 2017-05-12 01:23:31]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/84b6a842c0d92a52a557dbe102a9...