Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2875643004: Copy only accessed PersistentHistogramData fields when validating. (Closed)

Created:
3 years, 7 months ago by bcwhite
Modified:
3 years, 7 months ago
CC:
chromium-reviews, danakj+watch_chromium.org, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Copy only accessed PersistentHistogramData fields when validating. The DelayedPersistentAllocation added an atomic field to the PersistentHistogramData structure that cannot be copied using operator= (at least not without redefining it). Copies of only some of the fields are needed so explicitly copy only those; the atomic field is not one of them. BUG=721352 Review-Url: https://codereview.chromium.org/2875643004 Cr-Commit-Position: refs/heads/master@{#471143} Committed: https://chromium.googlesource.com/chromium/src/+/e0ecce46642e1d001deae09f41429c44517d84b9

Patch Set 1 #

Total comments: 4

Patch Set 2 : use local vars instead of local structure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -24 lines) Patch
M base/metrics/persistent_histogram_allocator.cc View 1 4 chunks +28 lines, -24 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
bcwhite
3 years, 7 months ago (2017-05-11 20:14:22 UTC) #5
Alexei Svitkine (slow)
https://codereview.chromium.org/2875643004/diff/1/base/metrics/persistent_histogram_allocator.cc File base/metrics/persistent_histogram_allocator.cc (right): https://codereview.chromium.org/2875643004/diff/1/base/metrics/persistent_histogram_allocator.cc#newcode575 base/metrics/persistent_histogram_allocator.cc:575: PersistentHistogramData histogram_data; Can you add a CopyTo() function instead? ...
3 years, 7 months ago (2017-05-11 20:20:07 UTC) #6
bcwhite
https://codereview.chromium.org/2875643004/diff/1/base/metrics/persistent_histogram_allocator.cc File base/metrics/persistent_histogram_allocator.cc (right): https://codereview.chromium.org/2875643004/diff/1/base/metrics/persistent_histogram_allocator.cc#newcode575 base/metrics/persistent_histogram_allocator.cc:575: PersistentHistogramData histogram_data; On 2017/05/11 20:20:07, Alexei Svitkine (slow) wrote: ...
3 years, 7 months ago (2017-05-11 20:23:16 UTC) #7
Alexei Svitkine (slow)
https://codereview.chromium.org/2875643004/diff/1/base/metrics/persistent_histogram_allocator.cc File base/metrics/persistent_histogram_allocator.cc (right): https://codereview.chromium.org/2875643004/diff/1/base/metrics/persistent_histogram_allocator.cc#newcode575 base/metrics/persistent_histogram_allocator.cc:575: PersistentHistogramData histogram_data; On 2017/05/11 20:23:16, bcwhite wrote: > On ...
3 years, 7 months ago (2017-05-11 20:27:56 UTC) #8
bcwhite
https://codereview.chromium.org/2875643004/diff/1/base/metrics/persistent_histogram_allocator.cc File base/metrics/persistent_histogram_allocator.cc (right): https://codereview.chromium.org/2875643004/diff/1/base/metrics/persistent_histogram_allocator.cc#newcode575 base/metrics/persistent_histogram_allocator.cc:575: PersistentHistogramData histogram_data; On 2017/05/11 20:27:55, Alexei Svitkine (slow) wrote: ...
3 years, 7 months ago (2017-05-11 21:03:29 UTC) #13
Alexei Svitkine (slow)
lgtm
3 years, 7 months ago (2017-05-11 21:06:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875643004/20001
3 years, 7 months ago (2017-05-11 21:49:23 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 00:30:30 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e0ecce46642e1d001deae09f4142...

Powered by Google App Engine
This is Rietveld 408576698