Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2875633003: Default md_browser.py to listen just on localhost (Closed)

Created:
3 years, 7 months ago by agrieve
Modified:
3 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Default md_browser.py to listen just on localhost It's a bit of security concern to expose a public server by default. The option is still maintained though, via --non-localhost Review-Url: https://codereview.chromium.org/2875633003 Cr-Commit-Position: refs/heads/master@{#471307} Committed: https://chromium.googlesource.com/chromium/src/+/37f3bb60cad9165bae952b7f95746ecb03342ff3

Patch Set 1 #

Patch Set 2 : remove flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M tools/md_browser/md_browser.py View 1 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
agrieve
🐒
3 years, 7 months ago (2017-05-10 16:35:41 UTC) #2
Dirk Pranke
lgtm, though I'd also be fine with (and possibly prefer) *only* listening on localhost and ...
3 years, 7 months ago (2017-05-11 02:10:31 UTC) #3
agrieve
On 2017/05/11 02:10:31, Dirk Pranke wrote: > lgtm, though I'd also be fine with (and ...
3 years, 7 months ago (2017-05-12 14:26:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875633003/20001
3 years, 7 months ago (2017-05-12 14:27:37 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 15:37:10 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/37f3bb60cad9165bae952b7f9574...

Powered by Google App Engine
This is Rietveld 408576698