Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(32)

Issue 2875613002: DevTools: Add CSS Grid Layout properties to CSSMetadata.js (Closed)

Created:
1 year, 8 months ago by Manuel Rego
Modified:
1 year, 8 months ago
Reviewers:
dgozman, lushnikov, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Add CSS Grid Layout properties to CSSMetadata.js The list of properties from the spec: https://drafts.csswg.org/css-grid/#property-index BUG=714069 Review-Url: https://codereview.chromium.org/2875613002 Cr-Commit-Position: refs/heads/master@{#470906} Committed: https://chromium.googlesource.com/chromium/src/+/8582d8e8c2d42a9ae105280b77f7f8a34979075c

Patch Set 1 #

Patch Set 2 : Rebased patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js View 1 2 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Manuel Rego
1 year, 8 months ago (2017-05-10 10:37:47 UTC) #2
dgozman
lgtm
1 year, 8 months ago (2017-05-10 16:45:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875613002/20001
1 year, 8 months ago (2017-05-11 07:03:22 UTC) #6
commit-bot: I haz the power
1 year, 8 months ago (2017-05-11 10:43:46 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8582d8e8c2d42a9ae105280b77f7...

Powered by Google App Engine
This is Rietveld 408576698