Create a new GN target //services/service_junit_tests, and enable it in bots.

Create a new GN target //services/service_junit_tests, and enable it in bots.

Move junit test of //device/generic_sensor into the new created services_junit_tests.

The junit test of generic_sensor is hosted in //device:device_junit_tests,
Before moving the generic_sensor from //device to //services/device (which is
one step of "generic_sensor servicification"), We have to create a new
service_junit_tests target for //services first.

The new created services_junit_tests is enabled in bots. This part is copy from:
  "Issue 2868693002: Device: enable device_junit_tests in bots".

BUG=689384
Review-Url: https://codereview.chromium.org/2875573003
Cr-Commit-Position: refs/heads/master@{#471551}
Committed: https://chromium.googlesource.com/chromium/src/+/af8ead2f5065e32be6f8a5572c6a38004e2c8984

[ke.he, 2017-05-10 06:26:43]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 06:27:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ke.he, 2017-05-10 06:38:08]

Description was changed from

==========
Create and enable //services/services_junit_tests.

Move junit test of //device/generic_sensor into the new created
services_junit_tests.

BUG=
==========

to

==========
Create and enable //services/services_junit_tests.

Move junit test of //device/generic_sensor into the new created
services_junit_tests.

Generic_sensor has junit test in //device:device_junit_tests. This CL moves them
from //device:device_junit_tests into //services:services_junit_tests.

The new created services_junit_tests is enabled in bots. This part is copy from:
  "Issue 2868693002: Device: enable device_junit_tests in bots".

BUG=689384
==========

[ke.he, 2017-05-10 06:41:30]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 06:41:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 08:30:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 08:30:22]

Dry run: This issue passed the CQ dry run.

[ke.he, 2017-05-10 08:40:19]

ke.he@intel.com changed reviewers:
+ blundell@chromium.org

[ke.he, 2017-05-10 08:40:20]

Hi, Colin,
I have an ongoing task:"move generic_sensor from //device to //services/device".
There is a build target |junit_binary("device_junit_test")| in //device so I
think we have to create a similar for //service to continue the code moving.

The bot enabling part is copied from Issue 2868693002.

PTAL. Thanks.

[blundell, 2017-05-10 14:51:57]

This looks fine to me, although you should get the same reviewer of the
device_junit_tests bot enabling to review that part of this CL as well. What is
the status of servicifying generic sensors? It seems strange to servicify the
test before the production code.

https://codereview.chromium.org/2875573003/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2875573003/diff/20001/BUILD.gn#newcode267
BUILD.gn:267: "//services:services_junit_tests",
nit: this should be service_junit_tests to match service_unittests.

[ke.he, 2017-05-11 03:12:18]

Description was changed from

==========
Create and enable //services/services_junit_tests.

Move junit test of //device/generic_sensor into the new created
services_junit_tests.

Generic_sensor has junit test in //device:device_junit_tests. This CL moves them
from //device:device_junit_tests into //services:services_junit_tests.

The new created services_junit_tests is enabled in bots. This part is copy from:
  "Issue 2868693002: Device: enable device_junit_tests in bots".

BUG=689384
==========

to

==========
Create a new GN target //services/service_junit_tests, and enable it in bots.

Move junit test of //device/generic_sensor into the new created
services_junit_tests.

The junit test of generic_sensor is hosted in //device:device_junit_tests,
Before moving the generic_sensor from //device to //services/device (which is
one step of "generic_sensor servicification"), We have to create a new
service_junit_tests target for //services first.

The new created services_junit_tests is enabled in bots. This part is copy from:
  "Issue 2868693002: Device: enable device_junit_tests in bots".

BUG=689384
==========

[ke.he, 2017-05-11 03:18:56]

Description was changed from

==========
Create a new GN target //services/service_junit_tests, and enable it in bots.

Move junit test of //device/generic_sensor into the new created
services_junit_tests.

The junit test of generic_sensor is hosted in //device:device_junit_tests,
Before moving the generic_sensor from //device to //services/device (which is
one step of "generic_sensor servicification"), We have to create a new
service_junit_tests target for //services first.

The new created services_junit_tests is enabled in bots. This part is copy from:
  "Issue 2868693002: Device: enable device_junit_tests in bots".

BUG=689384
==========

to

==========
Create a new GN target //services/service_junit_tests, and enable it in bots.

Move junit test of //device/generic_sensor into the new created
services_junit_tests.

The junit test of generic_sensor is hosted in //device:device_junit_tests,
Before moving the generic_sensor from //device to //services/device (which is
one step of "generic_sensor servicification"), We have to create a new
service_junit_tests target for //services first.

The new created services_junit_tests is enabled in bots. This part is copy from:
  "Issue 2868693002: Device: enable device_junit_tests in bots".

BUG=689384
==========

[ke.he, 2017-05-11 03:27:24]

Colin, I have two tasks in plan for servicifying generic sensors. One is "moving
generic_sensor from //device to //services/device", another is "add a service
unit test".
(As we discussed before in mail, so far we can just leave alone the browsertest
in //content.)

The first task is almost done(see https://codereview.chromium.org/2865263002/#)
while I find it is blocked when porting the junit test because there is no junit
test target in //services. That's why I use this CL to enable
"service_junit_tests" first for //services.

Thanks:)

[ke.he, 2017-05-11 03:28:19]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 03:29:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ke.he, 2017-05-11 03:31:20]

ke.he@intel.com changed reviewers:
+ jbudorick@chromium.org

[ke.he, 2017-05-11 03:31:21]

Hi, jbudorick@, Could you PTAL on this, thanks.

[commit-bot: I haz the power, 2017-05-11 05:04:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 05:04:18]

Dry run: This issue passed the CQ dry run.

[blundell, 2017-05-11 15:47:12]

lgtm, thanks!

I defer to jbudorick@ on the bot-related parts.

[jbudorick, 2017-05-11 17:12:42]

On 2017/05/11 03:31:21, ke.he wrote:
> Hi, jbudorick@, Could you PTAL on this, thanks.

lgtm

[ke.he, 2017-05-12 00:02:44]

ke.he@intel.com changed reviewers:
+ rockot@chromium.org

[ke.he, 2017-05-12 00:02:45]

Ken, PTAL on the //services and //device?  Thanks.

[Ken Rockot(use gerrit already), 2017-05-12 19:26:24]

lgtm

[ke.he, 2017-05-13 01:28:49]

The CQ bit was checked by ke.he@intel.com

[commit-bot: I haz the power, 2017-05-13 01:29:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 02:48:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 02:48:22]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ke.he, 2017-05-13 03:48:44]

The CQ bit was checked by ke.he@intel.com

[commit-bot: I haz the power, 2017-05-13 03:48:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 03:54:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494647324550360,
"parent_rev": "9c60f1f90829360d82ef3129370104f810644aa0", "commit_rev":
"af8ead2f5065e32be6f8a5572c6a38004e2c8984"}

[commit-bot: I haz the power, 2017-05-13 03:54:40]

Description was changed from

==========
Create a new GN target //services/service_junit_tests, and enable it in bots.

Move junit test of //device/generic_sensor into the new created
services_junit_tests.

The junit test of generic_sensor is hosted in //device:device_junit_tests,
Before moving the generic_sensor from //device to //services/device (which is
one step of "generic_sensor servicification"), We have to create a new
service_junit_tests target for //services first.

The new created services_junit_tests is enabled in bots. This part is copy from:
  "Issue 2868693002: Device: enable device_junit_tests in bots".

BUG=689384
==========

to

==========
Create a new GN target //services/service_junit_tests, and enable it in bots.

Move junit test of //device/generic_sensor into the new created
services_junit_tests.

The junit test of generic_sensor is hosted in //device:device_junit_tests,
Before moving the generic_sensor from //device to //services/device (which is
one step of "generic_sensor servicification"), We have to create a new
service_junit_tests target for //services first.

The new created services_junit_tests is enabled in bots. This part is copy from:
  "Issue 2868693002: Device: enable device_junit_tests in bots".

BUG=689384

Review-Url: https://codereview.chromium.org/2875573003
Cr-Commit-Position: refs/heads/master@{#471551}
Committed:
https://chromium.googlesource.com/chromium/src/+/af8ead2f5065e32be6f8a5572c6a...
==========

[commit-bot: I haz the power, 2017-05-13 03:54:41]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/af8ead2f5065e32be6f8a5572c6a...