Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2875563002: base: get rid of RealPath() function (Closed)

Created:
3 years, 7 months ago by tfarina
Modified:
3 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

base: get rid of RealPath() function Employ MakeAbsoluteFilePath() as it does the same thing. BUG=None TEST=base_unittests --gtest_filter=FileUtilTest.*Normalize* R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2875563002 Cr-Commit-Position: refs/heads/master@{#470579} Committed: https://chromium.googlesource.com/chromium/src/+/fc069bc236d7aef4b8ef18bf89e54f2f8b60d850

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M base/files/file_util_posix.cc View 2 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
tfarina
3 years, 7 months ago (2017-05-10 02:54:18 UTC) #3
Nico
lgtm, nice.
3 years, 7 months ago (2017-05-10 15:13:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875563002/1
3 years, 7 months ago (2017-05-10 15:14:21 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 15:22:38 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fc069bc236d7aef4b8ef18bf89e5...

Powered by Google App Engine
This is Rietveld 408576698