Add support for building v8 on mips and mips64 using GN.

Add support for building v8 on mips and mips64 using GN.

BUG=616017
R=machenbach@chromium.org, dpranke@chromium.org, brettw@chromium.org, ivica.bogosavljevic@imgtec.com

Review-Url: https://codereview.chromium.org/2875553003
Cr-Commit-Position: refs/heads/master@{#475506}
Committed: https://chromium.googlesource.com/chromium/src/+/4ba1f2ad0e20e132f082222ebcc53f1bf870a42d

[sreten.kovacevic, 2017-05-10 13:27:06]

Description was changed from

==========
Add support for building v8 on mips and mips64 using GN.

BUG=616017
R=machenbach@chromium.org, dpranke@chromium.org, brettw@chromium.org,
ivica.bogosavljevic@imgtec.com
==========

to

==========
Add support for building v8 on mips and mips64 using GN.

BUG=616017
R=machenbach@chromium.org, dpranke@chromium.org, brettw@chromium.org,
ivica.bogosavljevic@imgtec.com
==========

[Dirk Pranke, 2017-05-11 02:24:00]

lgtm

[sreten.kovacevic, 2017-05-15 09:05:22]

The CQ bit was checked by sreten.kovacevic@imgtec.com

[sreten.kovacevic, 2017-05-15 09:05:23]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2875553003/#ps20001
(title: "added cflags and removed nacl mips definition")

[commit-bot: I haz the power, 2017-05-15 09:05:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 09:14:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 09:14:32]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sreten.kovacevic, 2017-05-15 09:21:38]

Hello, I need lgtm from owner of:
build/config/BUILDCONFIG.gn

[Michael Achenbach, 2017-05-15 11:42:56]

On 2017/05/15 09:21:38, sreten.kovacevic wrote:
> Hello, I need lgtm from owner of:
> build/config/BUILDCONFIG.gn

lgtm, but for BUILDCONFIG.gn you'll need brettw's lgtm too.

[brettw, 2017-05-15 21:01:03]

Do you mind waiting a few days on this? A bunch of similar ones came at a
similar time I want to come up with a policy before adding more. Please ping me
in a few days if you haven't heard back.

[sreten.kovacevic, 2017-05-26 11:39:32]

On 2017/05/15 21:01:03, brettw wrote:
> Do you mind waiting a few days on this? A bunch of similar ones came at a
> similar time I want to come up with a policy before adding more. Please ping
me
> in a few days if you haven't heard back.

Can you tell me what is going on with this issue?

[brettw, 2017-05-30 04:05:07]

LGTM.

Sorry for the delay. The policy document isn't ready yet but I think everybody
agrees this V8 stuff will need to be supported, and that people's expectations
of support are hopefully correct, so I won't block any more on this.

[sreten.kovacevic, 2017-05-30 09:12:18]

The CQ bit was checked by sreten.kovacevic@imgtec.com

[commit-bot: I haz the power, 2017-05-30 09:12:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 10:57:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 10:57:59]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[sreten.kovacevic, 2017-05-30 11:09:43]

The CQ bit was checked by sreten.kovacevic@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 11:09:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 12:47:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 12:47:38]

Dry run: This issue passed the CQ dry run.

[sreten.kovacevic, 2017-05-30 12:53:55]

The CQ bit was checked by sreten.kovacevic@imgtec.com

[commit-bot: I haz the power, 2017-05-30 12:54:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 12:57:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496148835042010,
"parent_rev": "da1ebb6c4b424e74296c55b180055d1a98b73832", "commit_rev":
"4ba1f2ad0e20e132f082222ebcc53f1bf870a42d"}

[commit-bot: I haz the power, 2017-05-30 12:57:57]

Description was changed from

==========
Add support for building v8 on mips and mips64 using GN.

BUG=616017
R=machenbach@chromium.org, dpranke@chromium.org, brettw@chromium.org,
ivica.bogosavljevic@imgtec.com
==========

to

==========
Add support for building v8 on mips and mips64 using GN.

BUG=616017
R=machenbach@chromium.org, dpranke@chromium.org, brettw@chromium.org,
ivica.bogosavljevic@imgtec.com

Review-Url: https://codereview.chromium.org/2875553003
Cr-Commit-Position: refs/heads/master@{#475506}
Committed:
https://chromium.googlesource.com/chromium/src/+/4ba1f2ad0e20e132f082222ebcc5...
==========

[commit-bot: I haz the power, 2017-05-30 12:57:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4ba1f2ad0e20e132f082222ebcc5...

[brettw, 2017-05-31 17:00:42]

Here's the policy which should hopefully be unsurprising:

https://chromium.googlesource.com/chromium/src/+/master/docs/new_port_policy.md

[ivica.bogosavljevic, 2017-06-05 13:33:29]

On 2017/05/31 17:00:42, brettw wrote:
> Here's the policy which should hopefully be unsurprising:
> 
>
https://chromium.googlesource.com/chromium/src/+/master/docs/new_port_policy.md

V8 for MIPS big-endian was compiling using GYP for very long time. But in order
to support
compilation using GN, we need to add some modifications to GN files which are
part of Chromium
thereby introducing big-endian Chromium port.

We don't plan to support Chromium on MIPS big-endian, but we do plan to support
V8 on
MIPS big-endian. Please advise us what to do.

[brettw, 2017-06-05 17:59:10]

On 2017/06/05 13:33:29, ivica.bogosavljevic wrote:
> On 2017/05/31 17:00:42, brettw wrote:
> > Here's the policy which should hopefully be unsurprising:
> > 
> >
>
https://chromium.googlesource.com/chromium/src/+/master/docs/new_port_policy.md
> 
> V8 for MIPS big-endian was compiling using GYP for very long time. But in
order
> to support
> compilation using GN, we need to add some modifications to GN files which are
> part of Chromium
> thereby introducing big-endian Chromium port.
> 
> We don't plan to support Chromium on MIPS big-endian, but we do plan to
support
> V8 on
> MIPS big-endian. Please advise us what to do.

I think the current state is fine and you don't need to do anything.