Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2875543003: WebUI: Fix compile_js2.py to retrigger compilation for <include> files. (Closed)

Created:
3 years, 7 months ago by dpapad
Modified:
3 years, 7 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-closure_chromium.org, jlklein+watch-closure_chromium.org, vitalyp+closure_chromium.org, rbpotter
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: Fix compile_js2.py to retrigger compilation for <include> files. credit fix to dbeam@ BUG=720011 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2875543003 Cr-Commit-Position: refs/heads/master@{#470784} Committed: https://chromium.googlesource.com/chromium/src/+/078d397a6b7af9a6a41edc55e2567fc7520b235c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M chrome/browser/resources/print_preview/compiled_resources2.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/closure_compiler/build/get_includes.py View 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/closure_compiler/compile_js2.gypi View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
dpapad
3 years, 7 months ago (2017-05-11 01:24:33 UTC) #6
Dan Beam
what crazy person told you to do this!? lgtm
3 years, 7 months ago (2017-05-11 01:27:27 UTC) #7
dpapad
On 2017/05/11 at 01:27:27, dbeam wrote: > what crazy person told you to do this!? ...
3 years, 7 months ago (2017-05-11 01:41:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875543003/1
3 years, 7 months ago (2017-05-11 01:41:42 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 02:57:47 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/078d397a6b7af9a6a41edc55e256...

Powered by Google App Engine
This is Rietveld 408576698