Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2875533002: DevTools: inline SourceMaps should report data url as their url. (Closed)

Created:
3 years, 7 months ago by lushnikov
Modified:
3 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: inline SourceMaps should report data url as their url. This patch fixes SourceMap to actually report data url when asked via SourceMap.url() method. BUG=none R=dgozman Review-Url: https://codereview.chromium.org/2875533002 Cr-Commit-Position: refs/heads/master@{#470818} Committed: https://chromium.googlesource.com/chromium/src/+/a971d0c02ac324c9a11135422cba928a30840c30

Patch Set 1 #

Messages

Total messages: 21 (12 generated)
lushnikov
please, take a look
3 years, 7 months ago (2017-05-10 01:24:34 UTC) #1
dgozman
lgtm
3 years, 7 months ago (2017-05-10 19:16:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875533002/1
3 years, 7 months ago (2017-05-10 19:17:37 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450686)
3 years, 7 months ago (2017-05-10 21:20:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875533002/1
3 years, 7 months ago (2017-05-10 21:46:36 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450830)
3 years, 7 months ago (2017-05-10 23:56:46 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450830)
3 years, 7 months ago (2017-05-10 23:58:47 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875533002/1
3 years, 7 months ago (2017-05-11 03:18:15 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 05:17:45 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a971d0c02ac324c9a11135422cba...

Powered by Google App Engine
This is Rietveld 408576698