Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2875523002: metrics: Add BrickID charger type for Chrome OS. (Closed)

Created:
3 years, 7 months ago by Daniel Erat
Modified:
3 years, 7 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

metrics: Add BrickID charger type for Chrome OS. Update the PowerSupplyType enum to include BrickID, a new value used for proprietary Apple chargers. BUG=698133 Review-Url: https://codereview.chromium.org/2875523002 Cr-Commit-Position: refs/heads/master@{#470798} Committed: https://chromium.googlesource.com/chromium/src/+/17c3a61f0cf073a39f4d538c442b5885ce2b06ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/metrics/histograms/enums.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
use derat at chromium.org
benson, let me know if this looks reasonable. i wanted to include "BrickID" since that's ...
3 years, 7 months ago (2017-05-10 01:34:25 UTC) #2
teravest
lgtm
3 years, 7 months ago (2017-05-10 19:52:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875523002/1
3 years, 7 months ago (2017-05-10 19:54:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/423255)
3 years, 7 months ago (2017-05-10 20:08:10 UTC) #7
Benson Leung
fwiw, the patch looks good to me. On Tue, May 9, 2017 at 6:34 PM, ...
3 years, 7 months ago (2017-05-10 20:12:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875523002/1
3 years, 7 months ago (2017-05-11 02:39:08 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 03:50:56 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/17c3a61f0cf073a39f4d538c442b...

Powered by Google App Engine
This is Rietveld 408576698