metrics: Add BrickID charger type for Chrome OS.

metrics: Add BrickID charger type for Chrome OS.

Update the PowerSupplyType enum to include BrickID, a new
value used for proprietary Apple chargers.

BUG=698133
Review-Url: https://codereview.chromium.org/2875523002
Cr-Commit-Position: refs/heads/master@{#470798}
Committed: https://chromium.googlesource.com/chromium/src/+/17c3a61f0cf073a39f4d538c442b5885ce2b06ac

[use derat at chromium.org, 2017-05-10 01:34:25]

derat@google.com changed reviewers:
+ bleung@chromium.org, derat@google.com, teravest@chromium.org

[use derat at chromium.org, 2017-05-10 01:34:25]

benson, let me know if this looks reasonable. i wanted to include "BrickID"
since that's what we'll be getting from the kernel, but i figured it's also
helpful to mention in the string that this is apple.

i'm sending this from my google.com account because i have become stuck in a
state where i'm unable to switch rietveld to chromium.org. :-(

[teravest, 2017-05-10 19:52:25]

lgtm

[Daniel Erat, 2017-05-10 19:53:09]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2017-05-10 19:54:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 20:08:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 20:08:10]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Benson Leung, 2017-05-10 20:12:52]

fwiw, the patch looks good to me.

On Tue, May 9, 2017 at 6:34 PM, <derat@google.com> wrote:

> benson, let me know if this looks reasonable. i wanted to include "BrickID"
> since that's what we'll be getting from the kernel, but i figured it's also
> helpful to mention in the string that this is apple.
>
> i'm sending this from my google.com account because i have become stuck
> in a
> state where i'm unable to switch rietveld to chromium.org. :-(
>
> https://codereview.chromium.org/2875523002/
>



-- 
Benson Leung
Senior Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Daniel Erat, 2017-05-11 02:37:18]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2017-05-11 02:39:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 03:50:44]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494470238888310, "parent_rev":
"5b41f229340c9c26dadbbbc5686f0ed338a7a65a", "commit_rev":
"17c3a61f0cf073a39f4d538c442b5885ce2b06ac"}

[commit-bot: I haz the power, 2017-05-11 03:50:54]

Description was changed from

==========
metrics: Add BrickID charger type for Chrome OS.

Update the PowerSupplyType enum to include BrickID, a new
value used for proprietary Apple chargers.

BUG=698133
==========

to

==========
metrics: Add BrickID charger type for Chrome OS.

Update the PowerSupplyType enum to include BrickID, a new
value used for proprietary Apple chargers.

BUG=698133

Review-Url: https://codereview.chromium.org/2875523002
Cr-Commit-Position: refs/heads/master@{#470798}
Committed:
https://chromium.googlesource.com/chromium/src/+/17c3a61f0cf073a39f4d538c442b...
==========

[commit-bot: I haz the power, 2017-05-11 03:50:56]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/17c3a61f0cf073a39f4d538c442b...