cleanup: make WidgetClosingObserver as test support

cleanup: make WidgetClosingObserver as test support

changes:
(1) eliminate duplicates of WidgetClosingObserver into widget_test.h.
(2) several other cleanup into the current file. 

BUG=720525
TEST=covered by tests

Review-Url: https://codereview.chromium.org/2875513003
Cr-Commit-Position: refs/heads/master@{#471374}
Committed: https://chromium.googlesource.com/chromium/src/+/8362f111408e8ec8bfe8a34c77fa7ef13645cf99

[Qiang(Joe) Xu, 2017-05-10 05:12:08]

The CQ bit was checked by warx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 05:13:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 06:17:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 06:17:41]

Dry run: This issue passed the CQ dry run.

[Qiang(Joe) Xu, 2017-05-10 17:33:07]

Description was changed from

==========
cleanup: make WidgetClosingObserver as test support

BUG=
==========

to

==========
cleanup: make WidgetClosingObserver as test support

changes:
(1) eliminate duplicates of WidgetClosingObserver into widget_test.h.
(2) several other cleanup into the current file. 

BUG=none
==========

[Qiang(Joe) Xu, 2017-05-10 17:33:07]

warx@chromium.org changed reviewers:
+ sky@chromium.org

[Qiang(Joe) Xu, 2017-05-10 17:33:22]

Description was changed from

==========
cleanup: make WidgetClosingObserver as test support

changes:
(1) eliminate duplicates of WidgetClosingObserver into widget_test.h.
(2) several other cleanup into the current file. 

BUG=none
==========

to

==========
cleanup: make WidgetClosingObserver as test support

changes:
(1) eliminate duplicates of WidgetClosingObserver into widget_test.h.
(2) several other cleanup into the current file. 

BUG=none
TEST=covered by tests
==========

[Qiang(Joe) Xu, 2017-05-10 17:35:59]

Description was changed from

==========
cleanup: make WidgetClosingObserver as test support

changes:
(1) eliminate duplicates of WidgetClosingObserver into widget_test.h.
(2) several other cleanup into the current file. 

BUG=none
TEST=covered by tests
==========

to

==========
cleanup: make WidgetClosingObserver as test support

changes:
(1) eliminate duplicates of WidgetClosingObserver into widget_test.h.
(2) several other cleanup into the current file. 

BUG=720525
TEST=covered by tests
==========

[Qiang(Joe) Xu, 2017-05-10 17:36:15]

sky, PTAL thanks

[Qiang(Joe) Xu, 2017-05-11 20:44:44]

On 2017/05/10 17:36:15, Qiang(Joe) Xu wrote:
> sky, PTAL thanks

Friendly ping this to move up in the review list for the ease of writing test
coverage of https://codereview.chromium.org/2871073002/

[sky, 2017-05-12 14:04:56]

LGTM

[Qiang(Joe) Xu, 2017-05-12 16:24:50]

The CQ bit was checked by warx@chromium.org

[commit-bot: I haz the power, 2017-05-12 16:25:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 18:35:51]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494606290373720, "parent_rev":
"48ad581b3a0d4d098d6f312fe31a1a8083f20b8e", "commit_rev":
"8362f111408e8ec8bfe8a34c77fa7ef13645cf99"}

[commit-bot: I haz the power, 2017-05-12 18:36:01]

Description was changed from

==========
cleanup: make WidgetClosingObserver as test support

changes:
(1) eliminate duplicates of WidgetClosingObserver into widget_test.h.
(2) several other cleanup into the current file. 

BUG=720525
TEST=covered by tests
==========

to

==========
cleanup: make WidgetClosingObserver as test support

changes:
(1) eliminate duplicates of WidgetClosingObserver into widget_test.h.
(2) several other cleanup into the current file. 

BUG=720525
TEST=covered by tests

Review-Url: https://codereview.chromium.org/2875513003
Cr-Commit-Position: refs/heads/master@{#471374}
Committed:
https://chromium.googlesource.com/chromium/src/+/8362f111408e8ec8bfe8a34c77fa...
==========

[commit-bot: I haz the power, 2017-05-12 18:36:01]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8362f111408e8ec8bfe8a34c77fa...