Single user pod implementation for new login screen

Single user pod implementation for new login screen

The goal is to change the single user pod to match the ‘Single user’
section in the design spec.  

This CL implements everything about single user pod except:
1) Dynamically setting the color of the overlay based on user’s wallpaper. 
For now a fixed color is used, in the same way with OOBE screens.
2) The ripple effect of drop down menu arrow and header bar (In
addition, please note that the background of header bar changes to
transparent per the new spec).

All browser tests passed.

BUG=718158, 718156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2875513002
Cr-Commit-Position: refs/heads/master@{#471504}
Committed: https://chromium.googlesource.com/chromium/src/+/a80f688d6757bd90c05fa0ecd7cec210624e89ae

[Wenzhao (Colin) Zang, 2017-05-10 00:20:41]

Description was changed from

==========
Login screen redesign (CL 1)

BUG=718158, 718156
==========

to

==========
Login screen redesign (CL 1)

BUG=718158, 718156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Wenzhao (Colin) Zang, 2017-05-10 00:27:22]

Description was changed from

==========
Login screen redesign (CL 1)

BUG=718158, 718156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Login screen redesign (CL 1)

The goal is to make the single user login screen look the same with the new
design, without worrying much about the extensibility / reusability. Please
refer to
https://docs.google.com/a/google.com/document/d/1gILlP9VyBvfikcFZifkxZT4dEdZ1...
for more details.

All browsers tests passed.

BUG=718158, 718156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Wenzhao (Colin) Zang, 2017-05-10 00:27:23]

wzang@chromium.org changed reviewers:
+ alemate@chromium.org, jdufault@chromium.org

[Wenzhao (Colin) Zang, 2017-05-10 00:27:42]

Description was changed from

==========
Login screen redesign (CL 1)

The goal is to make the single user login screen look the same with the new
design, without worrying much about the extensibility / reusability. Please
refer to
https://docs.google.com/a/google.com/document/d/1gILlP9VyBvfikcFZifkxZT4dEdZ1...
for more details.

All browsers tests passed.

BUG=718158, 718156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Login screen redesign (CL 1)

The goal is to make the single user login screen look the same with the new
design, without worrying much about the extensibility / reusability. 

Please refer to
https://docs.google.com/a/google.com/document/d/1gILlP9VyBvfikcFZifkxZT4d
EdZ1nLFV__X6RHT9ZNg/edit?usp=sharing for more details.

All browsers tests passed.

BUG=718158, 718156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Wenzhao (Colin) Zang, 2017-05-10 00:27:58]

Description was changed from

==========
Login screen redesign (CL 1)

The goal is to make the single user login screen look the same with the new
design, without worrying much about the extensibility / reusability. 

Please refer to
https://docs.google.com/a/google.com/document/d/1gILlP9VyBvfikcFZifkxZT4d
EdZ1nLFV__X6RHT9ZNg/edit?usp=sharing for more details.

All browsers tests passed.

BUG=718158, 718156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Login screen redesign (CL 1)

The goal is to make the single user login screen look the same with the new
design, without worrying much about the extensibility / reusability. 

Please refer to
https://docs.google.com/a/google.com/document/d/1gILlP9VyBvfikcFZifkxZT4dEdZ1...
for more details.

All browsers tests passed.

BUG=718158, 718156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Wenzhao (Colin) Zang, 2017-05-10 00:28:18]

Description was changed from

==========
Login screen redesign (CL 1)

The goal is to make the single user login screen look the same with the new
design, without worrying much about the extensibility / reusability. 

Please refer to
https://docs.google.com/a/google.com/document/d/1gILlP9VyBvfikcFZifkxZT4dEdZ1...
for more details.

All browsers tests passed.

BUG=718158, 718156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Login screen redesign (CL 1)

The goal is to make the single user login screen look the same with the new
design, without worrying much about the extensibility / reusability. 

Please refer to
https://docs.google.com/a/google.com/document/d/1gILlP9VyBvfikcFZifkxZT4dEdZ1...
for more details.

All browsers tests passed.

BUG=718158, 718156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Wenzhao (Colin) Zang, 2017-05-10 00:28:28]

Description was changed from

==========
Login screen redesign (CL 1)

The goal is to make the single user login screen look the same with the new
design, without worrying much about the extensibility / reusability. 

Please refer to
https://docs.google.com/a/google.com/document/d/1gILlP9VyBvfikcFZifkxZT4dEdZ1...
for more details.

All browsers tests passed.

BUG=718158, 718156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Login screen redesign (CL 1)

The goal is to make the single user login screen look the same with the new
design, without worrying much about the extensibility / reusability. 

Please refer to
https://docs.google.com/a/google.com/document/d/1gILlP9VyBvfikcFZifkxZT4dEdZ1...
for more details.

All browser tests passed.

BUG=718158, 718156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jdufault, 2017-05-10 00:35:57]

Can you pull the md_header_bar.* fork into a separate CL, and make the
modifications to them in this CL?

[jdufault, 2017-05-10 00:40:07]

Generally seems good

https://codereview.chromium.org/2875513002/diff/1/ui/login/account_picker/md_...
File ui/login/account_picker/md_screen_account_picker.js (right):

https://codereview.chromium.org/2875513002/diff/1/ui/login/account_picker/md_...
ui/login/account_picker/md_screen_account_picker.js:157: if
(loadTimeData.getString('newOobeUI') == 'on')
I'm confused - this file should not be used in oobe?

https://codereview.chromium.org/2875513002/diff/1/ui/login/account_picker/md_...
ui/login/account_picker/md_screen_account_picker.js:210:
(activatedPod.getElementsByClassName('auth-container'))[0];
remove extra ()

https://codereview.chromium.org/2875513002/diff/1/ui/login/account_picker/md_...
File ui/login/account_picker/md_user_pod_row.js (right):

https://codereview.chromium.org/2875513002/diff/1/ui/login/account_picker/md_...
ui/login/account_picker/md_user_pod_row.js:3974: var nameElement =
nameArea.children[1];
Use a more specific selector?

[Wenzhao (Colin) Zang, 2017-05-11 18:13:36]

https://codereview.chromium.org/2875513002/diff/1/ui/login/account_picker/md_...
File ui/login/account_picker/md_screen_account_picker.js (right):

https://codereview.chromium.org/2875513002/diff/1/ui/login/account_picker/md_...
ui/login/account_picker/md_screen_account_picker.js:157: if
(loadTimeData.getString('newOobeUI') == 'on')
On 2017/05/10 00:40:07, jdufault wrote:
> I'm confused - this file should not be used in oobe?

Yes. I removed this part.

https://codereview.chromium.org/2875513002/diff/1/ui/login/account_picker/md_...
ui/login/account_picker/md_screen_account_picker.js:210:
(activatedPod.getElementsByClassName('auth-container'))[0];
On 2017/05/10 00:40:07, jdufault wrote:
> remove extra ()

Done.

https://codereview.chromium.org/2875513002/diff/1/ui/login/account_picker/md_...
File ui/login/account_picker/md_user_pod_row.js (right):

https://codereview.chromium.org/2875513002/diff/1/ui/login/account_picker/md_...
ui/login/account_picker/md_user_pod_row.js:3974: var nameElement =
nameArea.children[1];
On 2017/05/10 00:40:07, jdufault wrote:
> Use a more specific selector?

Done.

[Alexander Alekseev, 2017-05-12 04:17:54]

lgtm

https://codereview.chromium.org/2875513002/diff/20001/ui/login/account_picker...
File ui/login/account_picker/md_user_pod_template.html (right):

https://codereview.chromium.org/2875513002/diff/20001/ui/login/account_picker...
ui/login/account_picker/md_user_pod_template.html:53: <!-- iron-icon is imported
inside user_manager.html -->
You should import it again here, otherwise this will brake at some time.

<link rel="import" href="chrome://resources/cr_elements/icons.html">

is a no-op if already loaded.

[Wenzhao (Colin) Zang, 2017-05-12 20:52:06]

https://codereview.chromium.org/2875513002/diff/20001/ui/login/account_picker...
File ui/login/account_picker/md_user_pod_template.html (right):

https://codereview.chromium.org/2875513002/diff/20001/ui/login/account_picker...
ui/login/account_picker/md_user_pod_template.html:53: <!-- iron-icon is imported
inside user_manager.html -->
On 2017/05/12 04:17:54, Alexander Alekseev wrote:
> You should import it again here, otherwise this will brake at some time.
> 
> <link rel="import" href="chrome://resources/cr_elements/icons.html">
> 
> is a no-op if already loaded.

Done.

[Wenzhao (Colin) Zang, 2017-05-12 20:52:37]

The CQ bit was checked by wzang@chromium.org

[Wenzhao (Colin) Zang, 2017-05-12 20:52:37]

The patchset sent to the CQ was uploaded after l-g-t-m from alemate@chromium.org
Link to the patchset: https://codereview.chromium.org/2875513002/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2017-05-12 20:53:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 00:15:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494622357356610,
"parent_rev": "b40dc0c1f2fea886a3184e9c3265c9d9f8d7275f", "commit_rev":
"a80f688d6757bd90c05fa0ecd7cec210624e89ae"}

[commit-bot: I haz the power, 2017-05-13 00:15:35]

Description was changed from

==========
Login screen redesign (CL 1)

The goal is to make the single user login screen look the same with the new
design, without worrying much about the extensibility / reusability. 

Please refer to
https://docs.google.com/a/google.com/document/d/1gILlP9VyBvfikcFZifkxZT4dEdZ1...
for more details.

All browser tests passed.

BUG=718158, 718156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Login screen redesign (CL 1)

The goal is to make the single user login screen look the same with the new
design, without worrying much about the extensibility / reusability. 

Please refer to
https://docs.google.com/a/google.com/document/d/1gILlP9VyBvfikcFZifkxZT4dEdZ1...
for more details.

All browser tests passed.

BUG=718158, 718156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2875513002
Cr-Commit-Position: refs/heads/master@{#471504}
Committed:
https://chromium.googlesource.com/chromium/src/+/a80f688d6757bd90c05fa0ecd7ce...
==========

[commit-bot: I haz the power, 2017-05-13 00:15:46]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a80f688d6757bd90c05fa0ecd7ce...

[Wenzhao (Colin) Zang, 2017-05-26 04:30:05]

Description was changed from

==========
Login screen redesign (CL 1)

The goal is to make the single user login screen look the same with the new
design, without worrying much about the extensibility / reusability. 

Please refer to
https://docs.google.com/a/google.com/document/d/1gILlP9VyBvfikcFZifkxZT4dEdZ1...
for more details.

All browser tests passed.

BUG=718158, 718156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2875513002
Cr-Commit-Position: refs/heads/master@{#471504}
Committed:
https://chromium.googlesource.com/chromium/src/+/a80f688d6757bd90c05fa0ecd7ce...
==========

to

==========
Single user pod implementation for new login screen

The goal is to change the single user pod to match the ‘Single user’
section in the design spec.  

This CL implements everything about single user pod except:
1) Dynamically setting the color of the overlay based on user’s wallpaper. For
now a fixed color is used, in the same way with OOBE
screens.
2) The ripple effect of drop down menu arrow and header bar (In
addition, please note that the background of header bar changes to
transparent per the new spec).

All browser tests passed.

BUG=718158, 718156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2875513002
Cr-Commit-Position: refs/heads/master@{#471504}
Committed:
https://chromium.googlesource.com/chromium/src/+/a80f688d6757bd90c05fa0ecd7ce...
==========

[Wenzhao (Colin) Zang, 2017-05-26 04:31:00]

Description was changed from

==========
Single user pod implementation for new login screen

The goal is to change the single user pod to match the ‘Single user’
section in the design spec.  

This CL implements everything about single user pod except:
1) Dynamically setting the color of the overlay based on user’s wallpaper. For
now a fixed color is used, in the same way with OOBE
screens.
2) The ripple effect of drop down menu arrow and header bar (In
addition, please note that the background of header bar changes to
transparent per the new spec).

All browser tests passed.

BUG=718158, 718156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2875513002
Cr-Commit-Position: refs/heads/master@{#471504}
Committed:
https://chromium.googlesource.com/chromium/src/+/a80f688d6757bd90c05fa0ecd7ce...
==========

to

==========
Single user pod implementation for new login screen

The goal is to change the single user pod to match the ‘Single user’
section in the design spec.  

This CL implements everything about single user pod except:
1) Dynamically setting the color of the overlay based on user’s wallpaper. 
For now a fixed color is used, in the same way with OOBE
screens.
2) The ripple effect of drop down menu arrow and header bar (In
addition, please note that the background of header bar changes to
transparent per the new spec).

All browser tests passed.

BUG=718158, 718156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2875513002
Cr-Commit-Position: refs/heads/master@{#471504}
Committed:
https://chromium.googlesource.com/chromium/src/+/a80f688d6757bd90c05fa0ecd7ce...
==========

[Wenzhao (Colin) Zang, 2017-05-26 04:31:26]

Description was changed from

==========
Single user pod implementation for new login screen

The goal is to change the single user pod to match the ‘Single user’
section in the design spec.  

This CL implements everything about single user pod except:
1) Dynamically setting the color of the overlay based on user’s wallpaper. 
For now a fixed color is used, in the same way with OOBE
screens.
2) The ripple effect of drop down menu arrow and header bar (In
addition, please note that the background of header bar changes to
transparent per the new spec).

All browser tests passed.

BUG=718158, 718156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2875513002
Cr-Commit-Position: refs/heads/master@{#471504}
Committed:
https://chromium.googlesource.com/chromium/src/+/a80f688d6757bd90c05fa0ecd7ce...
==========

to

==========
Single user pod implementation for new login screen

The goal is to change the single user pod to match the ‘Single user’
section in the design spec.  

This CL implements everything about single user pod except:
1) Dynamically setting the color of the overlay based on user’s wallpaper. 
   For now a fixed color is used, in the same way with OOBE
screens.
2) The ripple effect of drop down menu arrow and header bar (In
addition, please note that the background of header bar changes to
transparent per the new spec).

All browser tests passed.

BUG=718158, 718156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2875513002
Cr-Commit-Position: refs/heads/master@{#471504}
Committed:
https://chromium.googlesource.com/chromium/src/+/a80f688d6757bd90c05fa0ecd7ce...
==========

[Wenzhao (Colin) Zang, 2017-05-26 04:31:47]

Description was changed from

==========
Single user pod implementation for new login screen

The goal is to change the single user pod to match the ‘Single user’
section in the design spec.  

This CL implements everything about single user pod except:
1) Dynamically setting the color of the overlay based on user’s wallpaper. 
   For now a fixed color is used, in the same way with OOBE
screens.
2) The ripple effect of drop down menu arrow and header bar (In
addition, please note that the background of header bar changes to
transparent per the new spec).

All browser tests passed.

BUG=718158, 718156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2875513002
Cr-Commit-Position: refs/heads/master@{#471504}
Committed:
https://chromium.googlesource.com/chromium/src/+/a80f688d6757bd90c05fa0ecd7ce...
==========

to

==========
Single user pod implementation for new login screen

The goal is to change the single user pod to match the ‘Single user’
section in the design spec.  

This CL implements everything about single user pod except:
1) Dynamically setting the color of the overlay based on user’s wallpaper. 
For now a fixed color is used, in the same way with OOBE screens.
2) The ripple effect of drop down menu arrow and header bar (In
addition, please note that the background of header bar changes to
transparent per the new spec).

All browser tests passed.

BUG=718158, 718156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2875513002
Cr-Commit-Position: refs/heads/master@{#471504}
Committed:
https://chromium.googlesource.com/chromium/src/+/a80f688d6757bd90c05fa0ecd7ce...
==========