Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2875493003: PaymentHandler: Remove PaymentAppManifest and PaymentAppOption. (Closed)

Created:
3 years, 7 months ago by zino
Modified:
3 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, gogerald+paymentswatch_chromium.org, Aaron Boodman, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, rouslan+payments_chromium.org, blink-reviews, darin-cc_chromium.org, mahmadi+paymentswatch_chromium.org, darin (slow to review), sebsg+paymentswatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PaymentHandler: Remove PaymentAppManifest and PaymentAppOption. They were already removed from the spec. Therefore, we should remove the related implementation. (including get/setManifest() methods in payment manager.) Spec: https://w3c.github.io/payment-handler/#paymentmanager-interface BUG=661608, 720040 Review-Url: https://codereview.chromium.org/2875493003 Cr-Commit-Position: refs/heads/master@{#472423} Committed: https://chromium.googlesource.com/chromium/src/+/6403f30a37f9ac07a05c4591ad8aabe202c96f05

Patch Set 1 #

Patch Set 2 : yaho #

Patch Set 3 : payment app #

Patch Set 4 : global-interface-listing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -942 lines) Patch
M components/payments/mojom/payment_app.mojom View 1 2 3 2 chunks +0 lines, -24 lines 0 comments Download
M content/browser/payments/payment_app.proto View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
M content/browser/payments/payment_app_content_unittest_base.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/payments/payment_app_content_unittest_base.cc View 1 1 chunk +0 lines, -36 lines 0 comments Download
M content/browser/payments/payment_app_context_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/payments/payment_app_database.h View 1 2 3 chunks +0 lines, -40 lines 0 comments Download
M content/browser/payments/payment_app_database.cc View 1 2 4 chunks +0 lines, -172 lines 0 comments Download
M content/browser/payments/payment_app_provider_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/payments/payment_app_provider_impl.cc View 2 chunks +0 lines, -32 lines 0 comments Download
M content/browser/payments/payment_app_provider_impl_unittest.cc View 1 2 4 chunks +0 lines, -69 lines 0 comments Download
M content/browser/payments/payment_manager.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/payments/payment_manager.cc View 1 1 chunk +0 lines, -19 lines 0 comments Download
M content/browser/payments/payment_manager_unittest.cc View 3 chunks +0 lines, -85 lines 0 comments Download
M content/public/browser/payment_app_provider.h View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/payments/payment-app-interfaces.html View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/payments/payment-manager.html View 1 chunk +0 lines, -219 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/payments/resources/payment-app.js View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 2 chunks +0 lines, -6 lines 0 comments Download
D third_party/WebKit/Source/modules/payments/PaymentAppManifest.idl View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/Source/modules/payments/PaymentAppOption.idl View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentManager.h View 1 2 3 chunks +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentManager.cpp View 4 chunks +0 lines, -157 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentManager.idl View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 28 (14 generated)
zino
PTAL
3 years, 7 months ago (2017-05-14 09:36:14 UTC) #4
zino
PTAL
3 years, 7 months ago (2017-05-14 09:36:26 UTC) #6
please use gerrit instead
lgtm
3 years, 7 months ago (2017-05-15 14:53:00 UTC) #7
haraken
modules/ LGTM
3 years, 7 months ago (2017-05-15 15:41:56 UTC) #8
zino
Tom Sepez@ PTAL
3 years, 7 months ago (2017-05-15 17:39:31 UTC) #10
Tom Sepez
RS LGTM on deleting code.
3 years, 7 months ago (2017-05-16 01:05:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875493003/40001
3 years, 7 months ago (2017-05-16 13:41:08 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/438216)
3 years, 7 months ago (2017-05-16 13:51:51 UTC) #15
zino
Avi@ for content/public PTAL
3 years, 7 months ago (2017-05-16 13:57:50 UTC) #17
Avi (use Gerrit)
lgtm
3 years, 7 months ago (2017-05-16 15:07:54 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875493003/40001
3 years, 7 months ago (2017-05-16 15:50:27 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/454841)
3 years, 7 months ago (2017-05-16 17:01:34 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875493003/60001
3 years, 7 months ago (2017-05-17 09:22:08 UTC) #25
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 11:37:05 UTC) #28
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/6403f30a37f9ac07a05c4591ad8a...

Powered by Google App Engine
This is Rietveld 408576698