Fix HandleJavaScriptDialog.

Fix HandleJavaScriptDialog.

The new dialogs had a bug where they misinterpreted a null pointer in HandleJavaScriptDialog as a request to return an empty string rather than the contents in the dialog.

Turning on the new dialogs for trunk revealed this on the Chromedriver bots, but there was no test coverage in Chromium proper to catch this.

This change adds testing for HandleJavaScriptDialog in the Chromium repo, and fixes the bug.

BUG=chromedriver:1792, 719551
TEST=re-enabled chromedriver test, new JavaScriptDialogTest.HandleJavaScriptDialog

Review-Url: https://codereview.chromium.org/2867613002
Cr-Commit-Position: refs/heads/master@{#470020}
(cherry picked from commit b38dc9a7d0f5457f892a031b407f0346b666430d)

Review-Url: https://codereview.chromium.org/2875473002 .
Cr-Commit-Position: refs/branch-heads/3071@{#492}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/969884aef39470a86a9f40a6dca712becab6b51b

[Avi (use Gerrit), 2017-05-09 23:43:25]

Description was changed from

==========
Fix HandleJavaScriptDialog.

The new dialogs had a bug where they misinterpreted a null pointer in
HandleJavaScriptDialog as a request to return an empty string rather than the
contents in the dialog.

Turning on the new dialogs for trunk revealed this on the Chromedriver bots, but
there was no test coverage in Chromium proper to catch this.

This change adds testing for HandleJavaScriptDialog in the Chromium repo, and
fixes the bug.

BUG=chromedriver:1792, 719551
TEST=re-enabled chromedriver test, new
JavaScriptDialogTest.HandleJavaScriptDialog

Review-Url: https://codereview.chromium.org/2867613002
Cr-Commit-Position: refs/heads/master@{#470020}
(cherry picked from commit b38dc9a7d0f5457f892a031b407f0346b666430d)
==========

to

==========
Fix HandleJavaScriptDialog.

The new dialogs had a bug where they misinterpreted a null pointer in
HandleJavaScriptDialog as a request to return an empty string rather than the
contents in the dialog.

Turning on the new dialogs for trunk revealed this on the Chromedriver bots, but
there was no test coverage in Chromium proper to catch this.

This change adds testing for HandleJavaScriptDialog in the Chromium repo, and
fixes the bug.

BUG=chromedriver:1792, 719551
TEST=re-enabled chromedriver test, new
JavaScriptDialogTest.HandleJavaScriptDialog

Review-Url: https://codereview.chromium.org/2867613002
Cr-Commit-Position: refs/heads/master@{#470020}
(cherry picked from commit b38dc9a7d0f5457f892a031b407f0346b666430d)

Review-Url: https://codereview.chromium.org/2875473002 .
Cr-Commit-Position: refs/branch-heads/3071@{#492}
Cr-Branched-From:
a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed:
https://chromium.googlesource.com/chromium/src/+/969884aef39470a86a9f40a6dca7...
==========

[Avi (use Gerrit), 2017-05-09 23:47:03]

Committed patchset #1 (id:1) manually as
969884aef39470a86a9f40a6dca712becab6b51b.