Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2875463002: [Devtools] Added sanity check for product registry's register function (Closed)

Created:
3 years, 7 months ago by allada
Modified:
3 years, 7 months ago
Reviewers:
einbinder, dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Added sanity check for product registry's register function Added a simple test to ensure that ProductRegistryImpl.register() handles the received data appropriately. [Mostly just a sanity check for the ProductRegistryData.js format] R=dgozman,pfeldman BUG=720133 Review-Url: https://codereview.chromium.org/2875463002 Cr-Commit-Position: refs/heads/master@{#474030} Committed: https://chromium.googlesource.com/chromium/src/+/7b779900fe4ae45ab5217311904203e2d71a0885

Patch Set 1 #

Patch Set 2 : changes #

Patch Set 3 : rebase #

Patch Set 4 : remove upstream #

Patch Set 5 : a #

Patch Set 6 : a #

Messages

Total messages: 19 (13 generated)
allada
PTL
3 years, 7 months ago (2017-05-09 23:18:47 UTC) #1
pfeldman
lgtm
3 years, 7 months ago (2017-05-10 20:50:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875463002/60001
3 years, 7 months ago (2017-05-17 22:04:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/458229)
3 years, 7 months ago (2017-05-17 23:40:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875463002/100001
3 years, 7 months ago (2017-05-23 19:11:04 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 20:18:44 UTC) #19
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/7b779900fe4ae45ab52173119042...

Powered by Google App Engine
This is Rietveld 408576698