Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2875453003:
Prune ComputeVisibleSelectionInDOMTreeDeprecated from SelectionController::UpdateSelectionForMouseD… (Closed)
|
Created:
3 years, 7 months ago by Xiaocheng Modified:
3 years, 7 months ago Reviewers:
yosin_UTC9 CC:
blink-reviews, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionPrune ComputeVisibleSelectionInDOMTreeDeprecated from SelectionController::UpdateSelectionForMouseDrag
This patch prunes a call site of the deprecated function, which is safe
because the call site has already updated layout.
BUG=698633
TEST=n/a; no behavioral changes.
Review-Url: https://codereview.chromium.org/2875453003
Cr-Commit-Position: refs/heads/master@{#471233}
Committed: https://chromium.googlesource.com/chromium/src/+/f32782b8769b529f5c6d476d6e8a45ea582dd39a
Patch Set 1 #
Messages
Total messages: 34 (30 generated)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?))
Description was changed from ========== Prune ComputeVisibleSelectionInDOMTreeDeprecated from SelectionController::UpdateSelectionForMouseDrag BUG= ========== to ========== Prune ComputeVisibleSelectionInDOMTreeDeprecated from SelectionController::UpdateSelectionForMouseDrag This patch prunes a call site of the deprecated function, which is safe because the call site has already updated layout. BUG= ==========
Description was changed from ========== Prune ComputeVisibleSelectionInDOMTreeDeprecated from SelectionController::UpdateSelectionForMouseDrag This patch prunes a call site of the deprecated function, which is safe because the call site has already updated layout. BUG= ========== to ========== Prune ComputeVisibleSelectionInDOMTreeDeprecated from SelectionController::UpdateSelectionForMouseDrag This patch prunes a call site of the deprecated function, which is safe because the call site has already updated layout. BUG=698633 TEST=n/a; no behavioral changes. ==========
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
xiaochengh@chromium.org changed reviewers: + yosin@chromium.org
PTAL.
The CQ bit was checked by yosin@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494566216609120, "parent_rev":
"b7551e1f750386296a285706691377b30c2daa98", "commit_rev":
"f32782b8769b529f5c6d476d6e8a45ea582dd39a"}
Message was sent while issue was closed.
Description was changed from ========== Prune ComputeVisibleSelectionInDOMTreeDeprecated from SelectionController::UpdateSelectionForMouseDrag This patch prunes a call site of the deprecated function, which is safe because the call site has already updated layout. BUG=698633 TEST=n/a; no behavioral changes. ========== to ========== Prune ComputeVisibleSelectionInDOMTreeDeprecated from SelectionController::UpdateSelectionForMouseDrag This patch prunes a call site of the deprecated function, which is safe because the call site has already updated layout. BUG=698633 TEST=n/a; no behavioral changes. Review-Url: https://codereview.chromium.org/2875453003 Cr-Commit-Position: refs/heads/master@{#471233} Committed: https://chromium.googlesource.com/chromium/src/+/f32782b8769b529f5c6d476d6e8a... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f32782b8769b529f5c6d476d6e8a... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
