Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Unified Diff: chrome/browser/about_flags.cc

Issue 287543002: Remove origin chip v1 and "hide on input" v2 behavior. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/search/search.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 4515540f88018dc57ee859f5ce5e138c58258c1d..5f5cb5410939359878892070979b597c20fc8fef 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -362,22 +362,8 @@ const Experiment::Choice kSearchButtonInOmniboxChoices[] = {
const Experiment::Choice kOriginChipChoices[] = {
{ IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
{ IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, switches::kDisableOriginChip, ""},
- { IDS_FLAGS_ORIGIN_CHIP_TRAILING_LOCATION_BAR,
- switches::kEnableOriginChipTrailingLocationBar, ""},
- { IDS_FLAGS_ORIGIN_CHIP_LEADING_LOCATION_BAR,
- switches::kEnableOriginChipLeadingLocationBar, ""},
- { IDS_FLAGS_ORIGIN_CHIP_LEADING_MENU_BUTTON,
- switches::kEnableOriginChipLeadingMenuButton, ""}
-};
-const Experiment::Choice kOriginChipV2Choices[] = {
- { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
- { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, switches::kDisableOriginChipV2, ""},
- { IDS_FLAGS_ORIGIN_CHIP_V2_HIDE_ON_MOUSE_RELEASE,
- switches::kEnableOriginChipV2HideOnMouseRelease, ""},
- { IDS_FLAGS_ORIGIN_CHIP_V2_HIDE_ON_USER_INPUT,
- switches::kEnableOriginChipV2HideOnUserInput, ""},
- { IDS_FLAGS_ORIGIN_CHIP_V2_ON_SRP,
- switches::kEnableOriginChipV2OnSrp, ""}
+ { IDS_FLAGS_ORIGIN_CHIP_ALWAYS, switches::kEnableOriginChipAlways, ""},
+ { IDS_FLAGS_ORIGIN_CHIP_ON_SRP, switches::kEnableOriginChipOnSrp, ""}
};
const Experiment::Choice kTouchScrollingModeChoices[] = {
@@ -1662,18 +1648,11 @@ const Experiment kExperiments[] = {
MULTI_VALUE_TYPE(kNumRasterThreadsChoices)
},
{
- "origin-chip",
+ "origin-chip-in-omnibox",
IDS_FLAGS_ORIGIN_CHIP_NAME,
IDS_FLAGS_ORIGIN_CHIP_DESCRIPTION,
- kOsCrOS | kOsWin | kOsLinux,
- MULTI_VALUE_TYPE(kOriginChipChoices)
- },
- {
- "origin-chip-in-omnibox",
- IDS_FLAGS_ORIGIN_CHIP_V2_NAME,
- IDS_FLAGS_ORIGIN_CHIP_V2_DESCRIPTION,
kOsCrOS | kOsMac | kOsWin | kOsLinux,
- MULTI_VALUE_TYPE(kOriginChipV2Choices)
+ MULTI_VALUE_TYPE(kOriginChipChoices)
},
{
"search-button-in-omnibox",
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/search/search.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698