Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 287543002: Remove origin chip v1 and "hide on input" v2 behavior. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/search/search.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 344 matching lines...) Expand 10 before | Expand all | Expand 10 after
355 switches::kEnableSearchButtonInOmniboxForStrOrIip, ""}, 355 switches::kEnableSearchButtonInOmniboxForStrOrIip, ""},
356 { IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_ENABLED, 356 { IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_ENABLED,
357 switches::kEnableSearchButtonInOmniboxAlways, ""} 357 switches::kEnableSearchButtonInOmniboxAlways, ""}
358 }; 358 };
359 359
360 // See comment above for kSearchButtonInOmniboxChoices. The same reasoning 360 // See comment above for kSearchButtonInOmniboxChoices. The same reasoning
361 // applies here. 361 // applies here.
362 const Experiment::Choice kOriginChipChoices[] = { 362 const Experiment::Choice kOriginChipChoices[] = {
363 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 363 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
364 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, switches::kDisableOriginChip, ""}, 364 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, switches::kDisableOriginChip, ""},
365 { IDS_FLAGS_ORIGIN_CHIP_TRAILING_LOCATION_BAR, 365 { IDS_FLAGS_ORIGIN_CHIP_ALWAYS, switches::kEnableOriginChipAlways, ""},
366 switches::kEnableOriginChipTrailingLocationBar, ""}, 366 { IDS_FLAGS_ORIGIN_CHIP_ON_SRP, switches::kEnableOriginChipOnSrp, ""}
367 { IDS_FLAGS_ORIGIN_CHIP_LEADING_LOCATION_BAR,
368 switches::kEnableOriginChipLeadingLocationBar, ""},
369 { IDS_FLAGS_ORIGIN_CHIP_LEADING_MENU_BUTTON,
370 switches::kEnableOriginChipLeadingMenuButton, ""}
371 };
372 const Experiment::Choice kOriginChipV2Choices[] = {
373 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
374 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, switches::kDisableOriginChipV2, ""},
375 { IDS_FLAGS_ORIGIN_CHIP_V2_HIDE_ON_MOUSE_RELEASE,
376 switches::kEnableOriginChipV2HideOnMouseRelease, ""},
377 { IDS_FLAGS_ORIGIN_CHIP_V2_HIDE_ON_USER_INPUT,
378 switches::kEnableOriginChipV2HideOnUserInput, ""},
379 { IDS_FLAGS_ORIGIN_CHIP_V2_ON_SRP,
380 switches::kEnableOriginChipV2OnSrp, ""}
381 }; 367 };
382 368
383 const Experiment::Choice kTouchScrollingModeChoices[] = { 369 const Experiment::Choice kTouchScrollingModeChoices[] = {
384 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 370 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
385 { IDS_FLAGS_TOUCH_SCROLLING_MODE_TOUCHCANCEL, 371 { IDS_FLAGS_TOUCH_SCROLLING_MODE_TOUCHCANCEL,
386 switches::kTouchScrollingMode, 372 switches::kTouchScrollingMode,
387 switches::kTouchScrollingModeTouchcancel }, 373 switches::kTouchScrollingModeTouchcancel },
388 { IDS_FLAGS_TOUCH_SCROLLING_MODE_ASYNC_TOUCHMOVE, 374 { IDS_FLAGS_TOUCH_SCROLLING_MODE_ASYNC_TOUCHMOVE,
389 switches::kTouchScrollingMode, 375 switches::kTouchScrollingMode,
390 switches::kTouchScrollingModeAsyncTouchmove }, 376 switches::kTouchScrollingModeAsyncTouchmove },
(...skipping 1264 matching lines...) Expand 10 before | Expand all | Expand 10 after
1655 }, 1641 },
1656 #endif 1642 #endif
1657 { 1643 {
1658 "num-raster-threads", 1644 "num-raster-threads",
1659 IDS_FLAGS_NUM_RASTER_THREADS_NAME, 1645 IDS_FLAGS_NUM_RASTER_THREADS_NAME,
1660 IDS_FLAGS_NUM_RASTER_THREADS_DESCRIPTION, 1646 IDS_FLAGS_NUM_RASTER_THREADS_DESCRIPTION,
1661 kOsAll, 1647 kOsAll,
1662 MULTI_VALUE_TYPE(kNumRasterThreadsChoices) 1648 MULTI_VALUE_TYPE(kNumRasterThreadsChoices)
1663 }, 1649 },
1664 { 1650 {
1665 "origin-chip", 1651 "origin-chip-in-omnibox",
1666 IDS_FLAGS_ORIGIN_CHIP_NAME, 1652 IDS_FLAGS_ORIGIN_CHIP_NAME,
1667 IDS_FLAGS_ORIGIN_CHIP_DESCRIPTION, 1653 IDS_FLAGS_ORIGIN_CHIP_DESCRIPTION,
1668 kOsCrOS | kOsWin | kOsLinux, 1654 kOsCrOS | kOsMac | kOsWin | kOsLinux,
1669 MULTI_VALUE_TYPE(kOriginChipChoices) 1655 MULTI_VALUE_TYPE(kOriginChipChoices)
1670 }, 1656 },
1671 { 1657 {
1672 "origin-chip-in-omnibox",
1673 IDS_FLAGS_ORIGIN_CHIP_V2_NAME,
1674 IDS_FLAGS_ORIGIN_CHIP_V2_DESCRIPTION,
1675 kOsCrOS | kOsMac | kOsWin | kOsLinux,
1676 MULTI_VALUE_TYPE(kOriginChipV2Choices)
1677 },
1678 {
1679 "search-button-in-omnibox", 1658 "search-button-in-omnibox",
1680 IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_NAME, 1659 IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_NAME,
1681 IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_DESCRIPTION, 1660 IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_DESCRIPTION,
1682 kOsCrOS | kOsMac | kOsWin | kOsLinux, 1661 kOsCrOS | kOsMac | kOsWin | kOsLinux,
1683 MULTI_VALUE_TYPE(kSearchButtonInOmniboxChoices) 1662 MULTI_VALUE_TYPE(kSearchButtonInOmniboxChoices)
1684 }, 1663 },
1685 { 1664 {
1686 "disable-ignore-autocomplete-off", 1665 "disable-ignore-autocomplete-off",
1687 IDS_FLAGS_DISABLE_IGNORE_AUTOCOMPLETE_OFF_NAME, 1666 IDS_FLAGS_DISABLE_IGNORE_AUTOCOMPLETE_OFF_NAME,
1688 IDS_FLAGS_DISABLE_IGNORE_AUTOCOMPLETE_OFF_DESCRIPTION, 1667 IDS_FLAGS_DISABLE_IGNORE_AUTOCOMPLETE_OFF_DESCRIPTION,
(...skipping 709 matching lines...) Expand 10 before | Expand all | Expand 10 after
2398 } 2377 }
2399 2378
2400 const Experiment* GetExperiments(size_t* count) { 2379 const Experiment* GetExperiments(size_t* count) {
2401 *count = num_experiments; 2380 *count = num_experiments;
2402 return experiments; 2381 return experiments;
2403 } 2382 }
2404 2383
2405 } // namespace testing 2384 } // namespace testing
2406 2385
2407 } // namespace about_flags 2386 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/search/search.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698