Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2875393003: Convert Download Tests to JUnit4 (Closed)

Created:
3 years, 7 months ago by the real yoland
Modified:
3 years, 7 months ago
CC:
chromium-reviews, David Trainor- moved to gerrit
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Download Tests to JUnit4 For more on JUnit4 migration, please check src/testing/android/docs/junit4.md BUG=640116 Review-Url: https://codereview.chromium.org/2875393003 Cr-Commit-Position: refs/heads/master@{#473746} Committed: https://chromium.googlesource.com/chromium/src/+/1ba8b6855fc458da0a571203c2b4b9233f756e22

Patch Set 1 #

Patch Set 2 : Fix ContextMenuTest issues #

Messages

Total messages: 19 (11 generated)
the real yoland
3 years, 7 months ago (2017-05-15 21:01:30 UTC) #4
the real yoland
This CL has more than scripted changes in TestRule and each test class. Activity launch ...
3 years, 7 months ago (2017-05-15 21:06:45 UTC) #6
mikecase (-- gone --)
non-owner lgtm!
3 years, 7 months ago (2017-05-15 21:23:28 UTC) #7
David Trainor- moved to gerrit
lgtm
3 years, 7 months ago (2017-05-17 16:39:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875393003/40001
3 years, 7 months ago (2017-05-18 20:35:34 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/431193)
3 years, 7 months ago (2017-05-19 02:04:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875393003/40001
3 years, 7 months ago (2017-05-22 22:17:42 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 23:36:29 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1ba8b6855fc458da0a571203c2b4...

Powered by Google App Engine
This is Rietveld 408576698