color: Make layout tests specify color space by command line flag

color: Make layout tests specify color space by command line flag

As we move layout tests to use the new color correct rendering flag,
we'll need to use this mechanism. This also is easier to test outside
of layout tests by just specifying the --force-color-profile flag.

BUG=713891
Review-Url: https://codereview.chromium.org/2875333003
Cr-Commit-Position: refs/heads/master@{#471662}
Committed: https://chromium.googlesource.com/chromium/src/+/009667de27f51fbf1877ceea08c037e35f3a5bdf

[ccameron, 2017-05-12 16:40:05]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 16:40:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-05-12 16:42:14]

ccameron@chromium.org changed reviewers:
+ avi@chromium.org

[ccameron, 2017-05-12 16:42:15]

ptal

This will probably require a few rebaselines on Mac, because the color
parameters for the two GenericRGB color spaces are different by ~0.002 or so.

[Avi (use Gerrit), 2017-05-12 17:33:06]

On 2017/05/12 16:42:15, ccameron wrote:
> ptal
> 
> This will probably require a few rebaselines on Mac, because the color
> parameters for the two GenericRGB color spaces are different by ~0.002 or so.

Code lg but there are gfx test failures in linux_chromium_tsan_rel_ng .

[commit-bot: I haz the power, 2017-05-12 17:35:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 17:35:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ccameron, 2017-05-12 20:44:55]

Thanks!

Oops, put the wrong constant in the test!

[Avi (use Gerrit), 2017-05-12 20:56:00]

On 2017/05/12 20:44:55, ccameron wrote:
> Thanks!
> 
> Oops, put the wrong constant in the test!

Can you upload a new version?

[ccameron, 2017-05-12 21:00:40]

Done.

Indeed there were lots of off-by-one errors with the layout tests (~300), so
I'll do the "./third_party/WebKit/Tools/Scripts/webkit-patch rebaseline-cl"
thing to update the layout tests.

[Avi (use Gerrit), 2017-05-12 21:06:38]

LGTM

[ccameron, 2017-05-14 17:17:47]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-14 17:17:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-14 18:35:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-14 18:35:54]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ccameron, 2017-05-15 00:08:28]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-05-15 00:08:30]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2875333003/#ps60001
(title: "Rebaseline tests")

[commit-bot: I haz the power, 2017-05-15 00:08:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 04:15:00]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494806908782240,
"parent_rev": "fe5ff7fddaf55aa6edfdad13f192089d25e7e3a8", "commit_rev":
"009667de27f51fbf1877ceea08c037e35f3a5bdf"}

[commit-bot: I haz the power, 2017-05-15 04:15:19]

Description was changed from

==========
color: Make layout tests specify color space by command line flag

As we move layout tests to use the new color correct rendering flag,
we'll need to use this mechanism. This also is easier to test outside
of layout tests by just specifying the --force-color-profile flag.

BUG=713891
==========

to

==========
color: Make layout tests specify color space by command line flag

As we move layout tests to use the new color correct rendering flag,
we'll need to use this mechanism. This also is easier to test outside
of layout tests by just specifying the --force-color-profile flag.

BUG=713891

Review-Url: https://codereview.chromium.org/2875333003
Cr-Commit-Position: refs/heads/master@{#471662}
Committed:
https://chromium.googlesource.com/chromium/src/+/009667de27f51fbf1877ceea08c0...
==========

[commit-bot: I haz the power, 2017-05-15 04:15:21]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/009667de27f51fbf1877ceea08c0...