Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2875323002: Remove unintentional dependency on analysis_server (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+556 lines, -145 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/name_suggestion.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/strings.dart View 5 chunks +2 lines, -64 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/util.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/naming_conventions.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/coverage_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/strings_test.dart View 6 chunks +0 lines, -45 lines 0 comments Download
M pkg/analysis_server/test/services/correction/util_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_core.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart View 10 chunks +398 lines, -24 lines 0 comments Download
A pkg/analyzer_plugin/lib/src/utilities/string_utilities.dart View 1 chunk +76 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_core.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_plugin/pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_plugin/test/src/utilities/change_builder/change_builder_core_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_plugin/test/src/utilities/change_builder/change_builder_dart_test.dart View 2 chunks +1 line, -1 line 0 comments Download
A pkg/analyzer_plugin/test/src/utilities/string_utilities_test.dart View 1 chunk +59 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/test/src/utilities/test_all.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 7 months ago (2017-05-12 14:35:39 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-12 15:34:18 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-05-12 17:07:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bef53e72e491933a383fc6e783cd7f344a66532c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698