Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: pkg/analysis_server/lib/src/services/refactoring/naming_conventions.dart

Issue 2875323002: Remove unintentional dependency on analysis_server (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library services.src.refactoring.naming_conventions;
6
7 import 'package:analysis_server/src/services/correction/status.dart'; 5 import 'package:analysis_server/src/services/correction/status.dart';
8 import 'package:analysis_server/src/services/correction/strings.dart'; 6 import 'package:analysis_server/src/services/correction/strings.dart';
7 import 'package:analyzer_plugin/src/utilities/string_utilities.dart';
9 import 'package:front_end/src/scanner/token.dart' show Keyword; 8 import 'package:front_end/src/scanner/token.dart' show Keyword;
10 9
11 /** 10 /**
12 * Returns the [RefactoringStatus] with severity: 11 * Returns the [RefactoringStatus] with severity:
13 * OK if the name is valid; 12 * OK if the name is valid;
14 * WARNING if the name is discouraged; 13 * WARNING if the name is discouraged;
15 * FATAL if the name is illegal. 14 * FATAL if the name is illegal.
16 */ 15 */
17 RefactoringStatus validateClassName(String name) { 16 RefactoringStatus validateClassName(String name) {
18 return _validateUpperCamelCase(name, "Class"); 17 return _validateUpperCamelCase(name, "Class");
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 } 254 }
256 // does not start with upper case 255 // does not start with upper case
257 if (!isUpperCase(identifier.codeUnitAt(0))) { 256 if (!isUpperCase(identifier.codeUnitAt(0))) {
258 // By convention, class names usually start with an uppercase letter 257 // By convention, class names usually start with an uppercase letter
259 String message = "$desc should start with an uppercase letter."; 258 String message = "$desc should start with an uppercase letter.";
260 return new RefactoringStatus.warning(message); 259 return new RefactoringStatus.warning(message);
261 } 260 }
262 // OK 261 // OK
263 return new RefactoringStatus(); 262 return new RefactoringStatus();
264 } 263 }
OLDNEW
« no previous file with comments | « pkg/analysis_server/lib/src/services/correction/util.dart ('k') | pkg/analysis_server/test/integration/coverage_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698