Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Unified Diff: third_party/WebKit/Source/core/svg/SVGUseElement.h

Issue 2875303002: Nested <use>s can resolve against an external resource (Closed)
Patch Set: Avoid adding observers for targets of nested <use> elements Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGUseElement.h
diff --git a/third_party/WebKit/Source/core/svg/SVGUseElement.h b/third_party/WebKit/Source/core/svg/SVGUseElement.h
index 274fb33568ad89cb0c0041b103838af18fc47121..eff2c0e3b00879d6b0ea49fe452c41957290cc2f 100644
--- a/third_party/WebKit/Source/core/svg/SVGUseElement.h
+++ b/third_party/WebKit/Source/core/svg/SVGUseElement.h
@@ -95,12 +95,16 @@ class SVGUseElement final : public SVGGraphicsElement,
}
// Instance tree handling
- Element* ResolveTargetElement();
+ enum ObserveBehavior {
+ kAddObserver,
+ kDontAddObserver,
+ };
+ Element* ResolveTargetElement(ObserveBehavior);
void BuildShadowAndInstanceTree(SVGElement& target);
void ClearInstanceRoot();
Element* CreateInstanceTree(SVGElement& target_root) const;
void ClearResourceReference();
- bool HasCycleUseReferencing(const SVGUseElement&,
+ bool HasCycleUseReferencing(SVGUseElement&,
const ContainerNode& target_instance,
SVGElement*& new_target) const;
bool ExpandUseElementsInShadowTree();

Powered by Google App Engine
This is Rietveld 408576698