Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGUseElement.h

Issue 2875303002: Nested <use>s can resolve against an external resource (Closed)
Patch Set: Avoid adding observers for targets of nested <use> elements Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann
3 * <zimmermann@kde.org> 3 * <zimmermann@kde.org>
4 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org> 4 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 } 88 }
89 89
90 bool SelfHasRelativeLengths() const override; 90 bool SelfHasRelativeLengths() const override;
91 91
92 ShadowRoot& UseShadowRoot() const { 92 ShadowRoot& UseShadowRoot() const {
93 CHECK(ClosedShadowRoot()); 93 CHECK(ClosedShadowRoot());
94 return *ClosedShadowRoot(); 94 return *ClosedShadowRoot();
95 } 95 }
96 96
97 // Instance tree handling 97 // Instance tree handling
98 Element* ResolveTargetElement(); 98 enum ObserveBehavior {
99 kAddObserver,
100 kDontAddObserver,
101 };
102 Element* ResolveTargetElement(ObserveBehavior);
99 void BuildShadowAndInstanceTree(SVGElement& target); 103 void BuildShadowAndInstanceTree(SVGElement& target);
100 void ClearInstanceRoot(); 104 void ClearInstanceRoot();
101 Element* CreateInstanceTree(SVGElement& target_root) const; 105 Element* CreateInstanceTree(SVGElement& target_root) const;
102 void ClearResourceReference(); 106 void ClearResourceReference();
103 bool HasCycleUseReferencing(const SVGUseElement&, 107 bool HasCycleUseReferencing(SVGUseElement&,
104 const ContainerNode& target_instance, 108 const ContainerNode& target_instance,
105 SVGElement*& new_target) const; 109 SVGElement*& new_target) const;
106 bool ExpandUseElementsInShadowTree(); 110 bool ExpandUseElementsInShadowTree();
107 void CloneNonMarkupEventListeners(); 111 void CloneNonMarkupEventListeners();
108 void AddReferencesToFirstDegreeNestedUseElements(SVGElement& target); 112 void AddReferencesToFirstDegreeNestedUseElements(SVGElement& target);
109 113
110 void InvalidateDependentShadowTrees(); 114 void InvalidateDependentShadowTrees();
111 115
112 bool ResourceIsStillLoading() const; 116 bool ResourceIsStillLoading() const;
113 bool ResourceIsValid() const; 117 bool ResourceIsValid() const;
(...skipping 13 matching lines...) Expand all
127 bool have_fired_load_event_; 131 bool have_fired_load_event_;
128 bool needs_shadow_tree_recreation_; 132 bool needs_shadow_tree_recreation_;
129 Member<SVGElement> target_element_instance_; 133 Member<SVGElement> target_element_instance_;
130 Member<IdTargetObserver> target_id_observer_; 134 Member<IdTargetObserver> target_id_observer_;
131 Member<DocumentResource> resource_; 135 Member<DocumentResource> resource_;
132 }; 136 };
133 137
134 } // namespace blink 138 } // namespace blink
135 139
136 #endif // SVGUseElement_h 140 #endif // SVGUseElement_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698