Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2875263002:
📷 Add toggling zoom and test title to RenderTest results. (Closed)
Description📷 Add toggling zoom and test title to RenderTest results.
BUG=614305
Review-Url: https://codereview.chromium.org/2875263002
Cr-Commit-Position: refs/heads/master@{#471761}
Committed: https://chromium.googlesource.com/chromium/src/+/0d5366d038448a862755eab685548c90bbbda7d5
Patch Set 1 #
Total comments: 2
Patch Set 2 : Switch to for...of loop. #
Total comments: 2
Patch Set 3 : Fixed stupid error. #
Messages
Total messages: 20 (5 generated)
peconn@chromium.org changed reviewers: + bauerb@chromium.org, jbudorick@chromium.org, mikecase@chromium.org
PTAL :-)
peconn@chromium.org changed reviewers: + bauerb@chromium.org, jbudorick@chromium.org, mikecase@chromium.org
PTAL :-)
PTAL :-)
https://codereview.chromium.org/2875263002/diff/1/build/android/pylib/instrum... File build/android/pylib/instrumentation/render_test.html.jinja (right): https://codereview.chromium.org/2875263002/diff/1/build/android/pylib/instrum... build/android/pylib/instrumentation/render_test.html.jinja:7: for (i = 0; i < imgs.length; i++) { Can you use for-of iteration (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/...
On 2017/05/12 10:55:28, Bernhard Bauer wrote: > https://codereview.chromium.org/2875263002/diff/1/build/android/pylib/instrum... > File build/android/pylib/instrumentation/render_test.html.jinja (right): > > https://codereview.chromium.org/2875263002/diff/1/build/android/pylib/instrum... > build/android/pylib/instrumentation/render_test.html.jinja:7: for (i = 0; i < > imgs.length; i++) { > Can you use for-of iteration > (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/...) John, is there a way to test this works locally?
https://codereview.chromium.org/2875263002/diff/1/build/android/pylib/instrum... File build/android/pylib/instrumentation/render_test.html.jinja (right): https://codereview.chromium.org/2875263002/diff/1/build/android/pylib/instrum... build/android/pylib/instrumentation/render_test.html.jinja:7: for (i = 0; i < imgs.length; i++) { On 2017/05/12 10:55:28, Bernhard Bauer wrote: > Can you use for-of iteration > (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/...) Done.
https://codereview.chromium.org/2875263002/diff/20001/build/android/pylib/ins... File build/android/pylib/instrumentation/render_test.html.jinja (right): https://codereview.chromium.org/2875263002/diff/20001/build/android/pylib/ins... build/android/pylib/instrumentation/render_test.html.jinja:7: if (imgs[i].hasAttribute('style')) { That should be |img| now, shouldn't it?
https://codereview.chromium.org/2875263002/diff/20001/build/android/pylib/ins... File build/android/pylib/instrumentation/render_test.html.jinja (right): https://codereview.chromium.org/2875263002/diff/20001/build/android/pylib/ins... build/android/pylib/instrumentation/render_test.html.jinja:7: if (imgs[i].hasAttribute('style')) { On 2017/05/12 14:15:21, Bernhard Bauer wrote: > That should be |img| now, shouldn't it? Ah yes, sorry - I had it right on my test page :-S
On 2017/05/12 13:01:12, PEConn wrote: > On 2017/05/12 10:55:28, Bernhard Bauer wrote: > > > https://codereview.chromium.org/2875263002/diff/1/build/android/pylib/instrum... > > File build/android/pylib/instrumentation/render_test.html.jinja (right): > > > > > https://codereview.chromium.org/2875263002/diff/1/build/android/pylib/instrum... > > build/android/pylib/instrumentation/render_test.html.jinja:7: for (i = 0; i < > > imgs.length; i++) { > > Can you use for-of iteration > > > (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/...) > > John, is there a way to test this works locally? Case is probably the better person to answer this. As written, it looks like you'd need to pass --gs-results-bucket to the test runner.
On 2017/05/12 at 14:31:23, jbudorick wrote: > On 2017/05/12 13:01:12, PEConn wrote: > > On 2017/05/12 10:55:28, Bernhard Bauer wrote: > > > > > https://codereview.chromium.org/2875263002/diff/1/build/android/pylib/instrum... > > > File build/android/pylib/instrumentation/render_test.html.jinja (right): > > > > > > > > https://codereview.chromium.org/2875263002/diff/1/build/android/pylib/instrum... > > > build/android/pylib/instrumentation/render_test.html.jinja:7: for (i = 0; i < > > > imgs.length; i++) { > > > Can you use for-of iteration > > > > > (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/...) > > > > John, is there a way to test this works locally? > > Case is probably the better person to answer this. As written, it looks like you'd need to pass --gs-results-bucket to the test runner. This is how I have been repro'ing things... out/Default/bin/run_chrome_public_test_apk -f org.chromium.chrome.browser.ntp.NewTabPageTest.testRender --gs-results-bucket chromium-render-results --json-results-file output.json -v --num-retries=0 build/android/pylib/results/presentation/test_results_presentation.py --json-file output.json --bucket chromium-render-tests --build-number 123 --test-name bar --builder-name foo Then the test_results_presentation.py script will print out a link to the results page. Swap out "chromium-render-results" with a bucket you can upload to (but you might just be able to leave as is, I gave write access to peconn@google.com for that bucket)
On 2017/05/12 15:43:12, mikecase wrote: > On 2017/05/12 at 14:31:23, jbudorick wrote: > > On 2017/05/12 13:01:12, PEConn wrote: > > > On 2017/05/12 10:55:28, Bernhard Bauer wrote: > > > > > > > > https://codereview.chromium.org/2875263002/diff/1/build/android/pylib/instrum... > > > > File build/android/pylib/instrumentation/render_test.html.jinja (right): > > > > > > > > > > > > https://codereview.chromium.org/2875263002/diff/1/build/android/pylib/instrum... > > > > build/android/pylib/instrumentation/render_test.html.jinja:7: for (i = 0; > i < > > > > imgs.length; i++) { > > > > Can you use for-of iteration > > > > > > > > (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/...) > > > > > > John, is there a way to test this works locally? > > > > Case is probably the better person to answer this. As written, it looks like > you'd need to pass --gs-results-bucket to the test runner. > > This is how I have been repro'ing things... > > out/Default/bin/run_chrome_public_test_apk -f > org.chromium.chrome.browser.ntp.NewTabPageTest.testRender --gs-results-bucket > chromium-render-results --json-results-file output.json -v --num-retries=0 > > build/android/pylib/results/presentation/test_results_presentation.py > --json-file output.json --bucket chromium-render-tests --build-number 123 > --test-name bar --builder-name foo > > Then the test_results_presentation.py script will print out a link to the > results page. Swap out "chromium-render-results" with a bucket you can upload to > (but you might just be able to leave as is, I gave write access to > mailto:peconn@google.com for that bucket) (We might want to work on an easier way to repro this, Case.)
lgtm
lgtm
The CQ bit was checked by peconn@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494855214249730,
"parent_rev": "9b5f619c25f1863ea049c7d5d5ae631d492f1e68", "commit_rev":
"0d5366d038448a862755eab685548c90bbbda7d5"}
Message was sent while issue was closed.
Description was changed from ========== 📷 Add toggling zoom and test title to RenderTest results. BUG=614305 ========== to ========== 📷 Add toggling zoom and test title to RenderTest results. BUG=614305 Review-Url: https://codereview.chromium.org/2875263002 Cr-Commit-Position: refs/heads/master@{#471761} Committed: https://chromium.googlesource.com/chromium/src/+/0d5366d038448a862755eab68554... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/0d5366d038448a862755eab68554... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
