|
|
DescriptionMove code from from ComputedStyleBase.cpp.tmpl to .h.tmpl
This patch moves code from ComputedStyleBase.cpp.tmpl to the h.tmpl
file in preparation to make it a template so that we can make
ComputedStyle a templated argument and access both functions on
ComputedStyleBase and ComputedStyle in the base class.
Diff: https://gist.github.com/nainar/f7cb9953674378504ac6795be365bb1f/revisions
BUG=710938
Review-Url: https://codereview.chromium.org/2875233002
Cr-Commit-Position: refs/heads/master@{#471664}
Committed: https://chromium.googlesource.com/chromium/src/+/6f28abba06b92fafe20371b82d81b13e6a8b6d6c
Patch Set 1 #
Total comments: 8
Patch Set 2 : Indent #
Dependent Patchsets: Messages
Total messages: 36 (22 generated)
The CQ bit was checked by nainar@chromium.org to run a CQ dry run
nainar@chromium.org changed reviewers: + shend@chromium.org
PTAL? Thanks!
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm after comments https://codereview.chromium.org/2875233002/diff/1/third_party/WebKit/Source/b... File third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl (right): https://codereview.chromium.org/2875233002/diff/1/third_party/WebKit/Source/b... third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl:102: )|indent(2)}} indent(4) https://codereview.chromium.org/2875233002/diff/1/third_party/WebKit/Source/b... third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl:111: )|indent(2)}} indent(4) https://codereview.chromium.org/2875233002/diff/1/third_party/WebKit/Source/b... third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl:130: )|indent(2)}} indent(4) https://codereview.chromium.org/2875233002/diff/1/third_party/WebKit/Source/b... third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl:139: )|indent(2)}} indent(4)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Move code from from ComputedStyleBase.cpp.tmpl to .h.tmpl This patch moves code from ComputedStyleBase.cpp.tmpl to the h.tmpl file in preparation to make it a template so that we can make ComputedStyle a templated argument and access both functions on ComputedStyleBase and ComputedStyle in the base class. Diff: https://gist.github.com/edff5fd43c6f90ee7514e1cb44f34e3d/revisions BUG=710938 ========== to ========== Move code from from ComputedStyleBase.cpp.tmpl to .h.tmpl This patch moves code from ComputedStyleBase.cpp.tmpl to the h.tmpl file in preparation to make it a template so that we can make ComputedStyle a templated argument and access both functions on ComputedStyleBase and ComputedStyle in the base class. Diff: https://gist.github.com/nainar/f7cb9953674378504ac6795be365bb1f/revisions BUG=710938 ==========
The CQ bit was checked by nainar@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
nainar@chromium.org changed reviewers: + alancutter@chromium.org
https://codereview.chromium.org/2875233002/diff/1/third_party/WebKit/Source/b... File third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl (right): https://codereview.chromium.org/2875233002/diff/1/third_party/WebKit/Source/b... third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl:102: )|indent(2)}} Done https://codereview.chromium.org/2875233002/diff/1/third_party/WebKit/Source/b... third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl:111: )|indent(2)}} Done. https://codereview.chromium.org/2875233002/diff/1/third_party/WebKit/Source/b... third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl:130: )|indent(2)}} Done. https://codereview.chromium.org/2875233002/diff/1/third_party/WebKit/Source/b... third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl:139: )|indent(2)}} Done.
lgtm
The CQ bit was unchecked by nainar@chromium.org
The CQ bit was checked by nainar@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from shend@chromium.org Link to the patchset: https://codereview.chromium.org/2875233002/#ps20001 (title: "Indent")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nainar@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nainar@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nainar@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nainar@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494821506051920, "parent_rev": "234813ae8d52f622a1664e11365642751e8f26ba", "commit_rev": "6f28abba06b92fafe20371b82d81b13e6a8b6d6c"}
Message was sent while issue was closed.
Description was changed from ========== Move code from from ComputedStyleBase.cpp.tmpl to .h.tmpl This patch moves code from ComputedStyleBase.cpp.tmpl to the h.tmpl file in preparation to make it a template so that we can make ComputedStyle a templated argument and access both functions on ComputedStyleBase and ComputedStyle in the base class. Diff: https://gist.github.com/nainar/f7cb9953674378504ac6795be365bb1f/revisions BUG=710938 ========== to ========== Move code from from ComputedStyleBase.cpp.tmpl to .h.tmpl This patch moves code from ComputedStyleBase.cpp.tmpl to the h.tmpl file in preparation to make it a template so that we can make ComputedStyle a templated argument and access both functions on ComputedStyleBase and ComputedStyle in the base class. Diff: https://gist.github.com/nainar/f7cb9953674378504ac6795be365bb1f/revisions BUG=710938 Review-Url: https://codereview.chromium.org/2875233002 Cr-Commit-Position: refs/heads/master@{#471664} Committed: https://chromium.googlesource.com/chromium/src/+/6f28abba06b92fafe20371b82d81... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/6f28abba06b92fafe20371b82d81... |