Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2875233002: Move code from from ComputedStyleBase.cpp.tmpl to .h.tmpl (Closed)

Created:
3 years, 7 months ago by nainar
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move code from from ComputedStyleBase.cpp.tmpl to .h.tmpl This patch moves code from ComputedStyleBase.cpp.tmpl to the h.tmpl file in preparation to make it a template so that we can make ComputedStyle a templated argument and access both functions on ComputedStyleBase and ComputedStyle in the base class. Diff: https://gist.github.com/nainar/f7cb9953674378504ac6795be365bb1f/revisions BUG=710938 Review-Url: https://codereview.chromium.org/2875233002 Cr-Commit-Position: refs/heads/master@{#471664} Committed: https://chromium.googlesource.com/chromium/src/+/6f28abba06b92fafe20371b82d81b13e6a8b6d6c

Patch Set 1 #

Total comments: 8

Patch Set 2 : Indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -90 lines) Patch
M third_party/WebKit/Source/build/scripts/make_computed_style_base.py View 2 chunks +0 lines, -9 lines 0 comments Download
D third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl View 1 chunk +0 lines, -70 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl View 1 5 chunks +59 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 36 (22 generated)
nainar
PTAL? Thanks!
3 years, 7 months ago (2017-05-12 01:10:24 UTC) #3
shend
lgtm after comments https://codereview.chromium.org/2875233002/diff/1/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl File third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl (right): https://codereview.chromium.org/2875233002/diff/1/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl#newcode102 third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl:102: )|indent(2)}} indent(4) https://codereview.chromium.org/2875233002/diff/1/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl#newcode111 third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl:111: )|indent(2)}} indent(4) ...
3 years, 7 months ago (2017-05-12 01:13:27 UTC) #5
nainar
https://codereview.chromium.org/2875233002/diff/1/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl File third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl (right): https://codereview.chromium.org/2875233002/diff/1/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl#newcode102 third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl:102: )|indent(2)}} Done https://codereview.chromium.org/2875233002/diff/1/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl#newcode111 third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl:111: )|indent(2)}} Done. https://codereview.chromium.org/2875233002/diff/1/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl#newcode130 third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl:130: )|indent(2)}} ...
3 years, 7 months ago (2017-05-12 03:23:48 UTC) #12
alancutter (OOO until 2018)
lgtm
3 years, 7 months ago (2017-05-12 03:56:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875233002/20001
3 years, 7 months ago (2017-05-12 04:28:27 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/382790)
3 years, 7 months ago (2017-05-12 06:20:38 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875233002/20001
3 years, 7 months ago (2017-05-12 06:25:49 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/382828)
3 years, 7 months ago (2017-05-12 07:58:32 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875233002/20001
3 years, 7 months ago (2017-05-12 08:57:47 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/383005)
3 years, 7 months ago (2017-05-12 10:34:52 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875233002/20001
3 years, 7 months ago (2017-05-14 23:48:45 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/454077)
3 years, 7 months ago (2017-05-15 01:37:22 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875233002/20001
3 years, 7 months ago (2017-05-15 04:12:02 UTC) #33
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 04:17:51 UTC) #36
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6f28abba06b92fafe20371b82d81...

Powered by Google App Engine
This is Rietveld 408576698