Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js

Issue 2875193002: DevTools: update text inputs to new style (Closed)
Patch Set: ac Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js b/third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js
index 294c0ba38a16cbdfffe4b7a9a59adac290bb887a..bbe082eeac99ef7a04af24ec000534ebebce17d2 100644
--- a/third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js
+++ b/third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js
@@ -76,18 +76,18 @@ Emulation.SensorsView = class extends UI.VBox {
var latitudeGroup = this._fieldsetElement.createChild('div', 'latlong-group');
var longitudeGroup = this._fieldsetElement.createChild('div', 'latlong-group');
- this._latitudeInput = latitudeGroup.createChild('input');
+ this._latitudeInput = UI.createInput('', 'number');
+ latitudeGroup.appendChild(this._latitudeInput);
this._latitudeInput.setAttribute('step', 'any');
- this._latitudeInput.setAttribute('type', 'number');
this._latitudeInput.value = 0;
this._latitudeSetter = UI.bindInput(
this._latitudeInput, this._applyGeolocationUserInput.bind(this),
SDK.EmulationModel.Geolocation.latitudeValidator, true);
this._latitudeSetter(String(geolocation.latitude));
- this._longitudeInput = longitudeGroup.createChild('input');
+ this._longitudeInput = UI.createInput('', 'number');
+ longitudeGroup.appendChild(this._longitudeInput);
this._longitudeInput.setAttribute('step', 'any');
- this._longitudeInput.setAttribute('type', 'number');
this._longitudeInput.value = 0;
this._longitudeSetter = UI.bindInput(
this._longitudeInput, this._applyGeolocationUserInput.bind(this),
@@ -312,17 +312,17 @@ Emulation.SensorsView = class extends UI.VBox {
fieldsetElement.classList.add('device-orientation-override-section');
var cellElement = fieldsetElement.createChild('td', 'orientation-inputs-cell');
- this._alphaElement = createElement('input');
+ this._alphaElement = UI.createInput();
this._alphaElement.setAttribute('step', 'any');
this._alphaSetter = this._createAxisInput(cellElement, this._alphaElement, Common.UIString('\u03B1 (alpha)'));
this._alphaSetter(String(deviceOrientation.alpha));
- this._betaElement = createElement('input');
+ this._betaElement = UI.createInput();
this._betaElement.setAttribute('step', 'any');
this._betaSetter = this._createAxisInput(cellElement, this._betaElement, Common.UIString('\u03B2 (beta)'));
this._betaSetter(String(deviceOrientation.beta));
- this._gammaElement = createElement('input');
+ this._gammaElement = UI.createInput();
this._gammaElement.setAttribute('step', 'any');
this._gammaSetter = this._createAxisInput(cellElement, this._gammaElement, Common.UIString('\u03B3 (gamma)'));
this._gammaSetter(String(deviceOrientation.gamma));

Powered by Google App Engine
This is Rietveld 408576698