third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js - Issue 2875193002: DevTools: update text inputs to new style

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

Issue 2875193002: DevTools: update text inputs to new style (Closed)

Patch Set: ac Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

index 0aefce0e9ee7ca8e81191c3d3af76f500165caa0..2ad4f24efae5953f324ae256fb2c297b3b21c5bd 100644

--- a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

+++ b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

@@ -93,9 +93,8 @@ Emulation.DeviceModeToolbar = class {

* @param {!UI.Toolbar} toolbar

_fillMainToolbar(toolbar) {

- var widthInput = createElementWithClass('input', 'device-mode-size-input');

+ var widthInput = UI.createInput('device-mode-size-input', 'text');

widthInput.maxLength = 4;

- widthInput.type = 'text';

widthInput.title = Common.UIString('Width');

this._updateWidthInput =

UI.bindInput(widthInput, this._applyWidth.bind(this), Emulation.DeviceModeModel.deviceSizeValidator, true);

@@ -108,9 +107,8 @@ Emulation.DeviceModeToolbar = class {

this._xItem = this._wrapToolbarItem(xElement);

toolbar.appendToolbarItem(this._xItem);

- var heightInput = createElementWithClass('input', 'device-mode-size-input');

+ var heightInput = UI.createInput('device-mode-size-input', 'text');

heightInput.maxLength = 4;

- heightInput.type = 'text';

heightInput.title = Common.UIString('Height (leave empty for full)');

this._updateHeightInput = UI.bindInput(heightInput, this._applyHeight.bind(this), validateHeight, true);

this._heightInput = heightInput;