Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 2875153002: Remove Experimental Flag ExternalAppPromptDisabled (Closed)

Created:
3 years, 7 months ago by pkl (ping after 24h if needed)
Modified:
3 years, 7 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, arv+watch_chromium.org, marq+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Experimental Flag ExternalAppPromptDisabled This was released a long time ago. Removing flag to clear clutter. BUG=338334 Review-Url: https://codereview.chromium.org/2875153002 Cr-Commit-Position: refs/heads/master@{#471162} Committed: https://chromium.googlesource.com/chromium/src/+/a04943571e3ab59ff3295fdaecb00259b39f883e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -28 lines) Patch
M ios/chrome/browser/experimental_flags.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/experimental_flags.mm View 2 chunks +0 lines, -6 lines 0 comments Download
M ios/chrome/browser/resources/Settings.bundle/Experimental.plist View 1 chunk +0 lines, -10 lines 0 comments Download
M ios/chrome/browser/web/external_app_launcher.mm View 1 chunk +7 lines, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (6 generated)
pkl (ping after 24h if needed)
3 years, 7 months ago (2017-05-11 21:17:24 UTC) #2
rohitrao (ping after 24h)
lgtm, thanks! BUG=338334 if you'd like
3 years, 7 months ago (2017-05-12 00:58:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875153002/1
3 years, 7 months ago (2017-05-12 01:00:41 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 01:15:55 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a04943571e3ab59ff3295fdaecb0...

Powered by Google App Engine
This is Rietveld 408576698